New option to generate reports in Markdown format --markdown
#405
Conversation
|
Very cool work @guillermocalvo, thanks for taking this up! |
japicmp/src/main/java/japicmp/output/markdown/MarkdownOutputGenerator.java
Outdated
Show resolved
Hide resolved
japicmp/src/main/java/japicmp/util/JApiClassFileFormatVersionHelper.java
Outdated
Show resolved
Hide resolved
Full explanation: JDK 8 doesn't realize we want to handle a stream of `JApiCompatibility` elements. Instead, the compiler thinks we want to create a stream of `JApiHasChangeStatus` elements. So I just extracted the complex expression to a constant with the appropriate type and it works fine. Other JDK versions get it right without the type hint. ¯\_(ツ)_/¯ Root cause of the problem: ``` Caused by: java.lang.invoke.LambdaConversionException: Invalid receiver type interface japicmp.model.JApiHasChangeStatus; not a subtype of implementation type interface japicmp.model.JApiCompatibility at java.lang.invoke.AbstractValidatingLambdaMetafactory.validateMetafactoryArgs(AbstractValidatingLambdaMetafactory.java:233) at java.lang.invoke.LambdaMetafactory.metafactory(LambdaMetafactory.java:303) at java.lang.invoke.CallSite.makeSite(CallSite.java:302) ... 54 more ```
Thanks for your review @siom79! I have implemented your suggestions. Incidentally, the JDK 8 build failed because the JVM was confused about some Java types 🤔 It's weird, because it was working perfectly fine two weeks ago, so I think the CI worker must be running a different version now. In any case, I extracted an expression to a constant to make sure the compiler understands what the types in play are. |
japicmp/src/main/java/japicmp/util/JApiClassFileFormatVersionHelper.java
Show resolved
Hide resolved
|
Thanks @guillermocalvo for implementing the changes. I have resolved the two last remarks myself and merged the result to main. Btw: Are you interested to become a collaborator on this repository? |
@siom79 Sounds great! Is there anything specific I can help with? |
|
@guillermocalvo I have sent you an invitation. Currently there is nothing specific, but as contributor you can merge PRs and do other helpful things. But please be cautious with the new power. 😏 |
|
@siom79 Thanks! And don't worry, I know that "with great power comes great responsibility". 😉 |
Solves #404
Note
An example Markdown report generated for demonstration purposes can be found here.
@siom79 Sorry for the big PR 😅 I tried to make this new functionality as customizable as possible. Please feel free to edit it or suggest any changes you think should be done before it can be merged.