Skip to content

Commit

Permalink
Remove TODOS.
Browse files Browse the repository at this point in the history
  • Loading branch information
sirEven committed Oct 3, 2024
1 parent c7fab1b commit 22ef36d
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 6 deletions.
3 changes: 0 additions & 3 deletions locast/candle_fetcher/dydx/api_fetcher/dydx_v3_fetcher.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,6 @@
from locast.candle_fetcher.dydx.api_fetcher.dydx_fetcher import DydxFetcher
from locast.candle_fetcher.exceptions import APIException


# TODO: Sort out Exception handling - maybe here an APIException might be fine - but it only should be raised when something goes wrong api wise - NOT when integrity errors or empty lists come back.
# OR no exception at all??
class DydxV3Fetcher(DydxFetcher):
def __init__(self, client: Client, rate_throttle_sec: float = 0.4) -> None:
self._exchange = Exchange.DYDX
Expand Down
3 changes: 0 additions & 3 deletions locast/candle_fetcher/dydx/api_fetcher/dydx_v4_fetcher.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,6 @@
from locast.candle_fetcher.dydx.api_fetcher.dydx_fetcher import DydxFetcher
from locast.candle_fetcher.exceptions import APIException


# TODO: Sort out Exception handling - maybe here an APIException might be fine - but it only should be raised when something goes wrong api wise - NOT when integrity errors or empty lists come back.
# OR no exception at all??
class DydxV4Fetcher(DydxFetcher):
def __init__(
self,
Expand Down

0 comments on commit 22ef36d

Please sign in to comment.