Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove sismo-connect-solidity library dependencies #43

Merged
merged 6 commits into from
Sep 7, 2023
Merged

feat: remove sismo-connect-solidity library dependencies #43

merged 6 commits into from
Sep 7, 2023

Conversation

yum0e
Copy link
Contributor

@yum0e yum0e commented Jul 27, 2023 •
edited
Loading

  • rewrite SismoConnectVerifier tests
  • rewrite HydraS3Verifier tests
  • remove builder libraries dependencies in tests and deployment scripts (libraries are now deployed in sismo-core/sismo-connect-solidity)

@yum0e yum0e mentioned this pull request Aug 17, 2023
Merged
4 tasks
@yum0e yum0e marked this pull request as ready for review August 17, 2023 08:26
@yum0e
feat: setup to deploy on base network (#44)
3553b10 
* feat: setup to deploy on base network

* feat: add deployment logs on base-goerli for core contracts

* feat: add deployment logs on base for core contracts

* feat: successfully deployed AddressesProvider contract on Base and
BaseGoerli networks
@leosayous21
Copy link
Member

leosayous21 commented Aug 23, 2023 •
edited
Loading

In src/utils there is some AuthBuilder, ClaimBuilder libraries, etc. that contains a lot of "build" function. I don't think this is necessary as in the code we are always using the same build function.
I would also put them as an internal library instead of external one

@yum0e
feat: remove useless build functions for testing purposes libraries
0bcf5bc 
(`AuthBuilder`, `ClaimBuilder` and `ProofBuilder`) + keep remaining as
internals
@yum0e yum0e merged commit 83913e1 into fix-use-view-function Sep 7, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yum0e @leosayous21