Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add hierarchical tag search #780

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hojerst
Copy link

@hojerst hojerst commented Jul 13, 2024

My shot at implementing a tag hierarchy at the search level for #659

Tags with / characters can be searched by any of its parents tags (i.e. a tag a/b/c is searchable via a, a/b or a/b/c.

Added an option to enable/disable this functionality in the user profile (default is off - aka old behaviour).

@anb-apg
Copy link

anb-apg commented Jul 17, 2024

Now this would be a great feature. I didn't have a look at the code, but one would have to search for #b, not b, right?

@hojerst
Copy link
Author

hojerst commented Jul 17, 2024

yes, normally you would search for tags via "#" prefix as normal.

it actually depends on your "tag search" setting as before. if it is set to "lax" it means you can search for tags without "#" as well. so no changes at the point.

@sissbruecker
Copy link
Owner

Thanks for the contribution. There definitely should be a better way to categorize bookmarks, but I'm not sure if this is it. The good thing about this implementation is that it's opt-in and a rather isolated change. Personally, I'd want something different for tag bundles though, in that I can define a bundle like programming which:

  • Is selectable through the UI, separately from the cluttered tag cloud
  • Allows me to define a number of tags like css, java, ... that are automatically included in the search results when searching for programming

I'll keep this open as an option, but I still have to make up my mind if categorization should be solved with folders, tag bundles, tag hierarchies, or by supporting multiple options. Or possibly a combination of those, for example folders could be combined somewhat with the tag bundle approach I mentioned above.

@anb-apg
Copy link

anb-apg commented Oct 15, 2024

I'll keep this open as an option, but I still have to make up my mind if categorization should be solved with folders, tag bundles, tag hierarchies, or by supporting multiple options. Or possibly a combination of those, for example folders could be combined somewhat with the tag bundle approach I mentioned above.

(Folders are the root of all evil - my personal opinion)

Could a bookmark then reside in multiple folders?

@hojerst
Copy link
Author

hojerst commented Oct 15, 2024

at least the main pull request here is nothing more then a partial tag search. this means you can organize your tags in a folder like hierarchy and then search for the path or the full tag name. this means you can have multiple hierarchical (or notmal) tags per link.

@sissbruecker
Copy link
Owner

(Folders are the root of all evil - my personal opinion)

I would agree with that. I hated it when every time I created a bookmark I had to decide in which folder to put it. Or digging through the folder hierarchy to find something. I much prefer just adding some tags and then relying on search. But people are used to them and it's one of the most requested features at this point. Apart from that the current tag cloud quickly becomes useless / too noisy if you want to navigate bookmarks through the UI rather than through search. So some form of a configurable curated list of categories (folders, tag bundles, whatever) as a quick filter makes sense.

Could a bookmark then reside in multiple folders?

With tag bundles very likely, as tags don't have a hierarchy and you can assign multiple of them to a bookmark. If there would be a feature for manually assigning bookmarks to folders then I'd probably not go that far in a first version.

@ccxuy
Copy link

ccxuy commented Oct 24, 2024

(Folders are the root of all evil - my personal opinion)

Could a bookmark then reside in multiple folders?

Kind of true, maybe put tags in folder, a tag belongs to some other tags (category), act like tags, but a bookmark still could be found via it's parent tag. Also when tag glows, the UI would become less messy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants