Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CAA DNS monitor cert_auth type issue #325

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix CAA DNS monitor cert_auth type issue #325

wants to merge 1 commit into from

Conversation

balazs92117
Copy link

Based on the current API (https://www.site24x7.com/help/api/#dns_search_config), site24x7_dns_server_monitor's search_config has certauth instead of cert_auth in case of CAA record type. This PR fixes this in the provider.

@balazs92117
Update types.go
92a762a 
Update SearchConfig's cert_auth to certauth
@balazs92117
Copy link
Author

I did not update the configuration itself, so it remains cert_auth instead of certauth for backward compatible reasons. But as the provider's documentation does not list the actual types for a DNS monitor's search_config, only links the official api, nobody will know how to use it. So probably we should update the config to.

@balazs92117 balazs92117 changed the title Update types.go Fix CAA DNS monitor cert_auth type issue Dec 9, 2024
@VinothDarwin-ZC VinothDarwin-ZC self-assigned this Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@VinothDarwin-ZC VinothDarwin-ZC

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@balazs92117 @VinothDarwin-ZC