-
Notifications
You must be signed in to change notification settings - Fork 574
feat: Add hierarchical settings file support with Claude CLI compatibility #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: Add hierarchical settings file support with Claude CLI compatibility #108
Conversation
…ility - Add support for ~/.claude/settings.json (global) and .claude/settings.json (project-specific) - Implement automatic conversion from Claude CLI format to claudecodeui format - Create unified settings management system with bidirectional sync - Add 'Currently Applied Rules' UI section showing active configuration - Support hierarchical settings with proper merge strategies - Add comprehensive error handling and validation - Include JSDoc documentation for all new functions - Maintain backwards compatibility with existing localStorage settings
|
@kosukesaigusa sorry it took me some time to review this one. This is an amazing addition. In some cases settings are not storred in .claude/settings but in ~/.claude.json In the backend, if I'm not mistaken I define that somewhere. Can you please check that and make sure it takes into account both of these files? |
viper151
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kosukesaigusa sorry it took me some time to review this one. This is an amazing addition.
In some cases settings are not storred in .claude/settings but in ~/.claude.json
It might be legacy but I remember I had that issue in some of the dev servers where .claude/settings.json was not present.
In the backend, if I'm not mistaken I define that somewhere. Can you please check that and make sure it takes into account both of these files?
|
@kosukesaigusa do you have any update on this one by any chance or shall I close this PR? |
viper151
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes requested in converation
Summary
This PR adds support for hierarchical settings files (
.claude/settings.json) to claudecodeui, enabling persistent configuration management and compatibility with Claude CLI settings format.Changes
Benefits
Screenshots
Manual Testing Performed
~/.claude/settings.jsonfileNote: This codebase doesn't have a test suite yet. Following the existing pattern, this PR doesn't include automated tests. Happy to add them in a follow-up PR if desired.
Migration
No breaking changes. Existing localStorage settings are preserved and will be migrated to settings files on first save.
Closes #109