TASK: Use @private instead of nested components #73
Conversation
mficzel
force-pushed
the
task/avoidNestedComponentsInFavorOfAtPrivateProps
branch
from
15c488d
to
25e1ee2
Compare
This will avoid the instantiation of a level of fusion objects and thus should improve performance
mficzel
force-pushed
the
task/avoidNestedComponentsInFavorOfAtPrivateProps
branch
from
750080b
to
1acc8f6
Compare
| @@ -5,51 +5,50 @@ prototype(Sitegeist.Kaleidoscope:Source) < prototype(Neos.Fusion:Component) { | |||
| } | |||
|
|
|||
| imageSource = null | |||
| [email protected] = ${value || __imageSource} | |||
There was a problem hiding this comment.
Where does this __imageSource come from?
There was a problem hiding this comment.
That is put into context from Picture so you do not have to specify it for every source when you do write sources as children like:
image = afx<Sitegeist.Kaleidoscope:Picture imageSource={props.source}> <Sitegeist.Kaleidoscope:Source format="webp" /> <Sitegeist.Kaleidoscope:Source format="png" /> </Sitegeist.Kaleidoscope:Picture>
There was a problem hiding this comment.
How does Eel interpret ||? What happens if value is false or null?
There was a problem hiding this comment.
If value is not null (exactly php falsy) the expression will yield value otherwise __imageSource
|
I think we should probably also remove all deprecated methods & (non-existing) eel helpers. Then release this as a breaking version. |
…Props * main: TASK: Make BaseUri argument nullable in DummyImageSource constructor FIX: Remove preserveAspect Replace $allowUpScaling with supportsUpscaling() FEATURE: Add quality option Empty srcCache on cloning TASK: Increase php requirement to 7.4 BUGFIX: Remove unnecessary named parameter FEATURE: Test mixed and invalid descriptors BUGFIX: Prevent division by zero FEATURE: Implement tests FEATURE: Only output existing images and allow upscaling Remove superfluous spaces Add new line for styleCI Add missing end of sentence marker for styleCI FEATURE: Runtime cache for `src` method of `AssetImageSource` # Conflicts: # Resources/Private/Fusion/Prototypes/Image.fusion # Resources/Private/Fusion/Prototypes/Picture.fusion # Resources/Private/Fusion/Prototypes/Source.fusion
mficzel
force-pushed
the
task/avoidNestedComponentsInFavorOfAtPrivateProps
branch
from
ab24399
to
781b7fb
Compare
This required Neos 8.3 + but should improve the performance as a level of fusion objects is avoided.