TASK: Remove the '[]' postfix from collection parameters as those wil…

…l use deepObject style now
sitegeist · Jun 7, 2024 · 36fd249 · 36fd249
1 parent 074774e
commit 36fd249
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/Classes/Domain/Path/OpenApiParameter.php b/Classes/Domain/Path/OpenApiParameter.php
@@ -69,7 +69,7 @@ public static function fromReflectionParameter(\ReflectionParameter $reflectionP
         $parameterSchema = OpenApiSchema::fromReflectionClass($reflectionClass);
 
         return new self(
-            name: $reflectionParameter->name . (($parameterAttribute->in === ParameterLocation::LOCATION_QUERY && $parameterSchema->type === 'array') ? '[]' : ''),
+            name: $reflectionParameter->name,
             in: $parameterAttribute->in,
             description: $parameterAttribute->description ?: $schemaAttribute->description,
             required: !$reflectionParameter->isDefaultValueAvailable(),

diff --git a/Tests/Unit/Application/ParameterFactoryTest.php b/Tests/Unit/Application/ParameterFactoryTest.php
@@ -118,9 +118,9 @@ public static function parameterProvider(): iterable
         $collectionParametersRequest = ActionRequest::fromHttpRequest(
             (new ServerRequest(
                 HttpMethod::METHOD_GET->value,
-                new Uri('https://acme.site/?identifierCollection[]=foo&identifierCollection[]=bar&identifier=baz')
+                new Uri('https://acme.site/?identifierCollection=foo&identifierCollection=bar&identifier=baz')
             ))->withQueryParams([
-                'identifierCollection' => ['foo','bar'],
+                'identifierCollection' => '["foo","bar"]',
                 'identifier' => 'baz'
             ])
         );

diff --git a/Tests/Unit/Domain/OpenApiDocumentFactoryTest.php b/Tests/Unit/Domain/OpenApiDocumentFactoryTest.php
@@ -480,7 +480,7 @@ public function testFromClassNameCreatesDefinitionsForValidClasses(): void
                                 style: ParameterStyle::STYLE_FORM
                             ),
                             new OpenApiParameter(
-                                name: 'identifierCollection[]',
+                                name: 'identifierCollection',
                                 description: '',
                                 in: ParameterLocation::LOCATION_QUERY,
                                 required: true,