Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: Allow simple types string, int, bool` as method arguments #2

Closed
wants to merge 8 commits into from

Conversation

mficzel
Copy link
Member

@mficzel mficzel commented Mar 19, 2024

This builts on top of #1 and adds supports string, int, bool as as parameter types from ParameterFactory

Also this switches from Endpoint to Action until flow supports other conrtroller patterns natively.

This change adds a the configuration of the available spec documents to the setting and uses the document names as
basis for rendering via cli-command  and controller.

Th cli `./flow .openapi:document __name__` will render the same spec as `openapi/specs/__name__`.

Also the setting `schemaTargetFilePath` is removed. The cli will output the spec directly to the shell where it can be sent wherever it is needed.
@mficzel mficzel requested a review from nezaniel March 19, 2024 16:34
@mficzel mficzel force-pushed the task/allowSimpleTypesAsParameters branch from a707607 to ead99aa Compare March 19, 2024 18:09
…ameter types from ParameterFactory

also switch from `Endpoint` to `Action` until flow supports other controller patterns natively
@mficzel mficzel force-pushed the task/allowSimpleTypesAsParameters branch from ead99aa to 1f7add8 Compare March 19, 2024 18:09
…y checking constructor arguments and returned values
@mficzel mficzel force-pushed the task/allowSimpleTypesAsParameters branch from 13b1c33 to ab45a9f Compare March 20, 2024 15:01
@mficzel mficzel force-pushed the task/allowSimpleTypesAsParameters branch from f3027ae to 0d08202 Compare March 20, 2024 21:01
@mficzel mficzel marked this pull request as draft March 21, 2024 18:44
@mficzel
Copy link
Member Author

mficzel commented Mar 21, 2024

Close in favor of the refactoring branch

@mficzel mficzel closed this Mar 21, 2024
@mficzel mficzel deleted the task/allowSimpleTypesAsParameters branch March 26, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant