TASK: Handle non null default values correctly
#20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mficzel
force-pushed
the
task/nonNullDefaultValues
branch
from
bdbb097
to
475362b
Compare
mficzel
changed the title
null default valuesnull default values correctly
mficzel
force-pushed
the
task/nonNullDefaultValues
branch
from
475362b
to
7a85c61
Compare
…on->resolveParameterFromRequest method that indicates that no value was passed and thus no parameter will be decoded or passed to the action
mficzel
force-pushed
the
task/nonNullDefaultValues
branch
from
f044d48
to
f39bc8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internally the
resolveParameterFromRequestmethod in theRequestBodyand theParameterLocationgot an additional return typeNoSuchParameterindicating that no values was passed.If the
NoSuchParametervalue is detected parameter decoding is skipped and no named parameter is added to the method call allowing either defaults to take effect or raise proper missing argument Exceptions.Fixes: #19