-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: FEATURE: Refactoring for Neos 9 #66
Draft
mficzel
wants to merge
35
commits into
main
Choose a base branch
from
neos-9
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The backend mule is basically working again
…bularies and taxonomies
… be in line with the property name
mficzel
changed the title
WIP: FEATURE: Refactioring for neos 9
WIP: FEATURE: Refactoring for Neos 9
Jun 19, 2023
- Adjust route path to be in /neos namesapace to avoid conflicts with frontendlogin - Adjust SecondaryInspectorController to new code and pass startingPoint and contextPath seperately - Various cleanups
3 tasks
as soon as the absolute path prs are merged all should become green
…iesAncestors`, `taxonomyDescendants`, `taxonomyChildren`, `taxonomyVocabularies` For now those operations are working on Nodes ... References support will be added later.
…ncestors`, `taxonomyWithDescendants`, `taxonomyWithAncestors`
ahaeslich
reviewed
Sep 16, 2023
TASK: Use named create constructor for all commands
- `referencedTaxonomies()`: the taxons referenced by the documents in flowQuery context - `referencingTaxonomies()`: the documents referencing by the taxons in flowQuery context - `subTaxonomies()` : sub-taxons of taxons in the context - `withSubTaxonomies()`: current taxons in the context plus sub-taxons
@ahaeslich i am usure about the names and interfaces of the flowQuery operations
|
…ing taxons directly below the vocabulary node
…Name->equals This is not exactly the same as the new solution includes subtypes but the isOf method requires the nodeTypeManager which is expensive.
ahaeslich
reviewed
Oct 17, 2023
also properly find reference vocabulary node
TASK: Adjust to renamed NodeTypeConstraints
Properly handle tethered nodes
BUGFIX: Adjust to Neos 9.0 UI changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flowQuery operations
referenceNodes()
andbackReferenceNodes
in combination to search for documents that have similar taxons assigned.The package now includes the following flowQuery operations:
referencedTaxonomies()
: the taxons referenced by the documents in flowQuery contextreferencingTaxonomies()
: the documents referencing by the taxons in flowQuery contextsubTaxonomies()
: sub-taxons of taxons in the contextwithSubTaxonomies()
: current taxons in the context plus sub-taxonsMust have:
Nice to have:
For now the following two branches are needed for this to work:
Neos !!! 9.0: Serious root nodes neos/neos-development-collection#4339Neos UI 9.0: Adjust to changed node path API neos/neos-ui#3530