Fix linting error and update new cli command description

sitespeedio · Sep 12, 2023 · 31ac351 · 31ac351
1 parent 4242208
commit 31ac351
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 16 deletions.
diff --git a/lib/chrome/webdriver/chromium.js b/lib/chrome/webdriver/chromium.js
@@ -160,7 +160,11 @@ export class Chromium {
       await this.android.resetPowerUsage();
     }
 
-    if (this.collectTracingEvents && !this.isTracing && this.options.chrome.timelineRecordingType !== 'custom' ) {
+    if (
+      this.collectTracingEvents &&
+      !this.isTracing &&
+      this.options.chrome.timelineRecordingType !== 'custom'
+    ) {
       this.isTracing = true;
       return this.cdpClient.startTrace();
     }
@@ -174,7 +178,11 @@ export class Chromium {
    */
   async afterPageCompleteCheck(runner, index, url, alias) {
     const result = { url, alias };
-    if (this.collectTracingEvents && this.isTracing && this.options.chrome.timelineRecordingType !== 'custom') {
+    if (
+      this.collectTracingEvents &&
+      this.isTracing &&
+      this.options.chrome.timelineRecordingType !== 'custom'
+    ) {
       // We are ready and can stop collecting events
       this.isTracing = false;
       this.events = await this.cdpClient.stopTrace();
@@ -334,7 +342,10 @@ export class Chromium {
       await this.storageManager.gzip(filename, gzFilename, true);
     }
 
-    if (this.collectTracingEvents && this.options.chrome.timelineRecordingType !== 'custom') {
+    if (
+      this.collectTracingEvents &&
+      this.options.chrome.timelineRecordingType !== 'custom'
+    ) {
       const trace = parse(this.events, result.url);
       const name = this.options.enableProfileRun
         ? `trace-${index}-extra-run.json`

diff --git a/lib/core/engine/command/chromeTrace.js b/lib/core/engine/command/chromeTrace.js
@@ -12,11 +12,10 @@ export class chromeTrace {
   constructor(engineDelegate, index, options, result) {
     this.engineDelegate = engineDelegate;
     this.options = options;
-    // this.result = context.result;
     this.result = result;
     this.index = index;
   }
-  
+
   async start() {
     if (this.options.browser === 'chrome') {
       if (this.options.chrome.timelineRecordingType === 'custom') {
@@ -97,7 +96,7 @@ export class chromeTrace {
         }
 
         if (!this.options.skipHar) {
-          for (let harRequest of this.hars[index - 1].log.entries) {
+          for (let harRequest of this.hars[this.index - 1].log.entries) {
             if (renderBlockingInfo[harRequest.request.url]) {
               harRequest._renderBlocking =
                 renderBlockingInfo[harRequest.request.url];
@@ -106,8 +105,7 @@ export class chromeTrace {
         }
 
         result.renderBlocking.requests = renderBlockingInfo;
-
-        }
+      }
     } else {
       throw new Error('Trace only works in Chrome');
     }

diff --git a/lib/core/engine/iteration.js b/lib/core/engine/iteration.js
@@ -165,12 +165,7 @@ export class Iteration {
         engineDelegate,
         options.browser
       );
-      const trace = new chromeTrace(
-        engineDelegate,
-        index,
-        options,
-        result
-      );
+      const trace = new chromeTrace(engineDelegate, index, options, result);
       const android = new Android(options);
       const debug = new Debug(browser, options);
       const commands = {

diff --git a/lib/support/cli.js b/lib/support/cli.js
@@ -276,8 +276,7 @@ export function parseCommandLine() {
     })
     .option('chrome.timelineRecordingType', {
       alias: 'chrome.traceRecordingType',
-      describe:
-        'Collect the timeline data. Drag and drop the JSON in your Chrome detvools timeline panel or check out the CPU metrics in the Browsertime.json',
+      describe: 'Expose the start/stop commands for the chrome trace',
       default: 'pageload',
       choices: ['pageload', 'custom'],
       type: 'string',