Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove video and simulator #2064

Merged
merged 4 commits into from
Jan 8, 2024
Merged

Remove video and simulator #2064

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
028e409
test mac build
soulgalore Jan 8, 2024
73617c5
boot in one step
soulgalore Jan 8, 2024
61c9af0
test video before simulators
soulgalore Jan 8, 2024
e3f71ea
disable video
soulgalore Jan 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 8 additions & 14 deletions .github/workflows/safari.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ on:
jobs:
build:
runs-on: macos-13
timeout-minutes: 30
timeout-minutes: 20
steps:
- uses: actions/checkout@v4
- name: Use Node.js
Expand All @@ -18,14 +18,9 @@ jobs:
node-version: '20.x'
- name: Install browsertime
run: npm ci
- name: Install python
uses: actions/setup-python@v4
with:
python-version: '3.11'
- name: Install dependencies
run: |
sudo safaridriver --enable
sudo rm '/usr/local/bin/2to3'
brew update
brew install ffmpeg
python -m pip install --upgrade --user pip
Expand All @@ -38,19 +33,18 @@ jobs:
ffmpeg -version
- name: List all simulators
run: xcrun xctrace list devices
- name: Boot iPhone 14
run: |
IPHONE14=$(xcrun xctrace list devices 2>&1 | grep -m 1 "iPhone 14 Simulator" | awk -F'[()]' '{print $4}')
xcrun simctl boot $IPHONE14
#- name: Start local HTTP server
# run: (npm run start-server&)
- name: Test Safari without video
run: ./bin/browsertime.js -b safari -n 1 https://www.sitespeed.io/
- name: Test Safari iOS simulator
run: |
IPHONE14=$(xcrun xctrace list devices 2>&1 | grep -m 1 "iPhone 14 Simulator" | awk -F'[()]' '{print $4}')
./bin/browsertime.js -b safari -n 1 --safari.useSimulator --video --visualMetrics --safari.deviceUDID $IPHONE14 https://www.sitespeed.io/
#- name: Test Safari with video and Visual Metrics
# run: ./bin/browsertime.js -b safari -n 1 --viewPort 800x600 --video --visualMetrics https://www.sitespeed.io/
#- name: Test Safari iOS simulator
# run: |
# IPHONE14=$(xcrun xctrace list devices 2>&1 | grep -m 1 "iPhone 14 Simulator" | awk -F'[()]' '{print $4}')
# xcrun simctl boot $IPHONE14
# echo "Booted $IPHONE14"
# ./bin/browsertime.js -b safari -n 1 --safari.useSimulator --video --visualMetrics --safari.deviceUDID $IPHONE14 https://www.sitespeed.io/

#- name: Test Safari with video and Visual Metrics for multi pages
# run: ./bin/browsertime.js -b safari -n 1 --viewPort 800x600 --video --visualMetrics test/data/navigationscript/multiMac.cjs