Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network.responseReceivedExtraInfo may be fired before or after responseReceived #120

Conversation

ifduyue
Copy link
Contributor

@ifduyue ifduyue commented Jul 11, 2024

Fix issue #119

From https://chromedevtools.github.io/devtools-protocol/tot/Network/#event-responseReceivedExtraInfo

responseReceivedExtraInfo may be fired before or after responseReceived.

Here is a reproduce https://gist.github.com/ifduyue/d850df87c1f58e4d1d4303e82e21e5fe

# inspect messages.json uploaded by me
# OR
git clone https://gist.github.com/d850df87c1f58e4d1d4303e82e21e5fe.git
cd d850df87c1f58e4d1d4303e82e21e5fe
npm i
node index.js
# and then inspect messages.json

Viewing the generated messages.json from this gist, we can observer that for "requestId": "98243.71", Network.responseReceivedExtraInfo was fired before responseReceived.

@ifduyue ifduyue force-pushed the responseReceivedExtraInfo-fired-after-responseReceived branch from 2b7eafe to 2f28ddf Compare July 11, 2024 05:13
@soulgalore
Copy link
Member

Hi @ifduyue thanks for the PR! Can you please run npm run lint:fix to fix your lint issues, then the tests can move on.

@ifduyue
Copy link
Contributor Author

ifduyue commented Jul 11, 2024

@soulgalore done

@soulgalore soulgalore merged commit 4f3c43f into sitespeedio:main Jul 12, 2024
3 checks passed
@soulgalore
Copy link
Member

Thank you @ifduyue for your fix!

@ifduyue ifduyue deleted the responseReceivedExtraInfo-fired-after-responseReceived branch July 12, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants