Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install the arm64 binary if we are on an arm64 macOS #14

Merged
merged 1 commit into from
Nov 26, 2023

Conversation

canova
Copy link
Contributor

@canova canova commented Nov 26, 2023

Hi @soulgalore!

Browsertime was failing to capture Firefox Profiler profiles with the "power" profiling feature enabled on my and @mrchrisadams's machines. After doing some debugging, I realized that it's because of the geckodriver binary we had. We are still using the x86_64 binary in arm64 machines and Marionette protocol was throwing some errors with this feature enabled. After switching to arm64 binary, I can confirm that the issue is fixed.

Here's a command to reproduce:

./bin/browsertime.js https://sitespeed.io -b firefox --firefox.geckoProfiler --firefox.geckoProfilerParams.features "power" -n 1

This was failing on arm64. I also tested on x84_64 macbooks and it doesn't fail there. When I manually update the sitespeedio/geckodriver dependency to use this branch, the issue gets fixed.

Also, this came up from the discussions in sitespeedio/sitespeed.io#3944

@soulgalore soulgalore merged commit 9bd1923 into sitespeedio:main Nov 26, 2023
4 checks passed
@soulgalore
Copy link
Member

Thank you @canova !

@canova canova deleted the arm64-macos branch November 29, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants