Install the arm64 binary if we are on an arm64 macOS #14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @soulgalore!
Browsertime was failing to capture Firefox Profiler profiles with the "power" profiling feature enabled on my and @mrchrisadams's machines. After doing some debugging, I realized that it's because of the geckodriver binary we had. We are still using the x86_64 binary in arm64 machines and Marionette protocol was throwing some errors with this feature enabled. After switching to arm64 binary, I can confirm that the issue is fixed.
Here's a command to reproduce:
This was failing on arm64. I also tested on x84_64 macbooks and it doesn't fail there. When I manually update the
sitespeedio/geckodriver
dependency to use this branch, the issue gets fixed.Also, this came up from the discussions in sitespeedio/sitespeed.io#3944