Replace lodash.pullAll and lodash.union (#4386)

sitespeedio · Jan 7, 2025 · 9597140 · 9597140
1 parent 25c4aa2
commit 9597140
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 18 deletions.
diff --git a/lib/sitespeed.js b/lib/sitespeed.js
@@ -7,8 +7,6 @@ import fs from 'node:fs/promises';
 import dayjs from 'dayjs';
 import utc from 'dayjs/plugin/utc.js';
 import { getLogger } from '@sitespeed.io/log';
-import pullAll from 'lodash.pullall';
-import union from 'lodash.union';
 
 import { configure } from './core/logging.js';
 import { toArray } from './support/util.js';
@@ -103,8 +101,11 @@ export async function run(options) {
     // Finalize the plugins that we wanna run
     // First we add the new ones and then remove, that means remove
     // always wins
-    pluginNames = union(pluginNames, toArray(plugins.add));
-    pullAll(pluginNames, toArray(plugins.remove));
+    pluginNames = [...new Set([...pluginNames, ...toArray(plugins.add)])];
+
+    const removeSet = new Set(toArray(plugins.remove));
+    pluginNames = pluginNames.filter(name => !removeSet.has(name));
+
     if (plugins.list) {
       log.info('The following plugins are enabled: %s', pluginNames.join(', '));
     }

diff --git a/npm-shrinkwrap.json b/npm-shrinkwrap.json
diff --git a/package.json b/package.json
@@ -104,10 +104,8 @@
     "lodash.isempty": "4.4.0",
     "lodash.merge": "4.6.2",
     "lodash.pick": "4.4.0",
-    "lodash.pullall": "4.2.0",
     "lodash.reduce": "4.6.0",
     "lodash.set": "4.3.2",
-    "lodash.union": "4.6.0",
     "markdown": "0.5.0",
     "node-scp": "0.0.23",
     "ora": "8.0.1",