Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Debian/Ubuntu support and others install fixes #922

Merged
merged 3 commits into from
Jan 16, 2025

Conversation

pgrenaud
Copy link

Related to #907. This PR:

  • Fix Debian/Ubuntu (apt) dependencies.
    • Remove the chromium-browser package as chromium is provided (downloaded) by nuclei.
    • Split the dependencies for chromium to be compatible with various Ubuntu versions. This address the compatibility issue with Ubuntu 24.04 mentioned in Multiple issues when installing on Ubuntu 24.04 #907.
    • Use apt-get as apt should not be use for scripting.
  • Add ~/.cargo/bin in path (Rust) in reconftw.cfg. After adding Add --check-tools option and GitHub workflow #920, I noticed that one of the tools was missing. This was due to the .bashrc file not being reloaded after running ./install.sh. Since the Golang environment variables are added in this file, I did the same for Cargo/Rust.
  • Add missing tools in tools check. Some tools check were missing from ./reconftw.sh. This help to detect if./install.sh failed to install the system packages (which happens if one of the packages does not exists or if there is a choice to make).

@six2dez six2dez merged commit 5503e7c into six2dez:dev Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants