update compatibility with java version 17 #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlresende
approved these changes
Apr 14, 2023
|
Hi @rlresende. Can you merge this PR? |
|
Hello @ksetoue ! How as you going? I would like to merge this PR for you but I don't have permission :-/ |
|
It would be really good to have this, no other tool provides the flexibility for unit tests that fixture-factory does IMO. If the maintainers aren't active anymore, can this perhaps be forked? |
|
hey folks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I used fixture-factory with java 8 a few years ago and it worked really well even with kotlin projects. Now I have a project that targets a java17 and after days trying to find a fixture library to use, decided to change the source code to add the compatibility I need.
I know that no updates have been made to this lib in a while, but I would be happy to contribute in this project because the idea is pretty solid and makes writing tests easy. Regardless, I hope this can help some people out there that still uses this project
Can you take a look and validate if this change makes sense to this project?