Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not consider incompetent jobs to be killed #337

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Nov 29, 2017

Fixes #336.

@codecov-io
Copy link

codecov-io commented Nov 29, 2017

Codecov Report

Merging #337 into master will decrease coverage by 0.11%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #337      +/-   ##
==========================================
- Coverage   83.33%   83.21%   -0.12%     
==========================================
  Files          46       46              
  Lines        1416     1418       +2     
  Branches      138      138              
==========================================
  Hits         1180     1180              
- Misses        216      218       +2     
  Partials       20       20
Flag Coverage Δ
#py34 83.07% <0%> (-0.12%) ⬇️
#py35 82.93% <0%> (-0.12%) ⬇️
#py36 82.93% <0%> (-0.12%) ⬇️
#pynightly 82.93% <0%> (-0.12%) ⬇️
Impacted Files Coverage Δ
cosmic_ray/reporting.py 39.06% <0%> (-1.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48e55c4...34ee4bf. Read the comment docs.

@blueyed
Copy link
Contributor Author

blueyed commented Nov 29, 2017

Is this code really not covered?
Or is it not picked up by pytest-cov correctly?
Experimenting in #338, #339 and #340.

@abingham
Copy link
Contributor

It may not be covered. It's definitely stuff I haven't spent a lot of testing time on.

@abingham
Copy link
Contributor

One problem with this change is that the survival_rate() method needs to be updated. It needs to consider "incompetent" mutants as killed, or at least as "not survivors". I guess this points to the need for a test that generates an incompetent mutants as well (which should just be another issue).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants