cr-filter-git: mark all as skipped in single transaction #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This sounds great. When I'm back from vacation I'll look it over and likely merge it right in. Thanks!
Sent from ProtonMail mobile
…-------- Original Message --------
On Dec 29, 2023, 12:35, Hubert Kario wrote:
Because every skipped transaction is committed individually to the DB, it takes extensive amount of time for a database with few tens of thousands of mutants:
without the patch:
18.08user 3.50system 1:12.85elapsed 29%CPU (0avgtext+0avgdata 116220maxresident)k
0inputs+1014816outputs (0major+27993minor)pagefaults 0swaps
with this patch:
10.33user 0.18system 0:10.55elapsed 99%CPU (0avgtext+0avgdata 116008maxresident)k
0inputs+3176outputs (0major+27989minor)pagefaults 0swaps
And this is with a fairly fast NVME SSD, slower disk storage will take extensively more time.
---------------------------------------------------------------
You can view, comment on, or merge this pull request online at:
#541
Commit Summary
- [9ae3554](9ae3554) cr-filter-git: mark all as skipped in single transaction
File Changes
([2 files](https://github.com/sixty-north/cosmic-ray/pull/541/files))
- M [src/cosmic_ray/tools/filters/git.py](https://github.com/sixty-north/cosmic-ray/pull/541/files#diff-691b9ae60652da9323dbf170ef2420021c101d378b87ff57a2d7219e5ad30115) (19)
- M [src/cosmic_ray/work_db.py](https://github.com/sixty-north/cosmic-ray/pull/541/files#diff-f678d6f93370a582fe87003254e828355bc31f20f1785d86ee65ddd659dc2a11) (20)
Patch Links:
- https://github.com/sixty-north/cosmic-ray/pull/541.patch
- https://github.com/sixty-north/cosmic-ray/pull/541.diff
—
Reply to this email directly, [view it on GitHub](#541), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AAATK6CGOYIXVOTHFX2W5ATYL4EO7AVCNFSM6AAAAABBG44NKOVHI2DSMVQWIX3LMV43ASLTON2WKOZSGA3DAMZRHA3TOOI).
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because every skipped transaction is committed individually to the DB, it takes extensive amount of time for a database with few tens of thousands of mutants:
without the patch:
with this patch:
And this is with a fairly fast NVME SSD, slower disk storage will take extensively more time.