Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure splitlines is not called on None #161

Merged
merged 2 commits into from
Oct 21, 2023
Merged

Make sure splitlines is not called on None #161

merged 2 commits into from
Oct 21, 2023

Conversation

ptosco
Copy link
Contributor

@ptosco ptosco commented Oct 20, 2023

Small change that avoids that splitlines is called on a None object; this may currently happen if prop.fget.__doc__ exists and is None, thus causing an exception ('NoneType' object has no attribute 'splitlines').

@sizmailov sizmailov enabled auto-merge (squash) October 21, 2023 00:40
@sizmailov sizmailov merged commit e367e9c into sizmailov:master Oct 21, 2023
12 checks passed
@sizmailov
Copy link
Owner

Thanks for the fix!

@ptosco ptosco deleted the none-splitlines branch October 23, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ptosco @sizmailov