take 68

changelog.md

@@ -1,6 +1,6 @@
 ### ?, ? - V1.9.3.
 
-- Added free-running smooth noise as a new LFO type.
+- Added free-running smooth noise as a new LFO type. Note - consecutive cycles are not smooth by themselves so you still need to use the LFO filter to get a real smooth signal.
 - Bugfix in generating random numbers for the per-voice-random cv source (they weren't all that random).
 - Breaking change: lfo noise generators become phase-based sampling functions to prevent drift.
 * This causes small and possibly audible differences for the (free-running-) static and smooth lfos, sorry, but was needed to keep engine and ui in check.

src/firefly_synth/firefly_synth/lfo.cpp

@@ -610,9 +610,9 @@ lfo_engine::reset_graph(
   if (seen_rand_seed)
   {
     if(is_noise_static(block_auto[param_shape][0].step()))
-      _static_noise.init(new_rand_seed, block_auto[param_steps][0].step(), false);
+      _static_noise.init(new_rand_seed, block_auto[param_steps][0].step());
     else
-      _smooth_noise.init(new_rand_seed, block_auto[param_steps][0].step(), false);
+      _smooth_noise.init(new_rand_seed, block_auto[param_steps][0].step());
   }
 
   _noise_graph_was_init = true;

src/firefly_synth/firefly_synth/noise_generator.hpp

@@ -32,17 +32,17 @@ class noise_generator
 
 public:
   float at(float phase) const;
+  void init(int seed, int steps);
   int seed() const { return _seed; }
-  void init(int seed, int steps, bool connect);
-  void resample() { init(_state, _steps, true); }; // for free-run
+  void resample() { init(_state, _steps); }; // for free-run
 
   noise_generator() {} // needs init
   noise_generator(int seed, int steps) 
-  { init(plugin_base::fast_rand_seed(seed), steps, false); }
+  { init(plugin_base::fast_rand_seed(seed), steps); }
 };
 
 template <bool Smooth> inline void 
-noise_generator<Smooth>::init(int seed, int steps, bool connect)
+noise_generator<Smooth>::init(int seed, int steps)
 {
   _seed = seed;
   _state = seed;