fix: revert \inserttitlegraphic to the original definition #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
josephwright/beamer#849 在 default 模板里引入了 titlegraphic beamer template 导致了这种循环引用的情况，也就意味着 TeX Live 2023 及之前并无此问题。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
撤销 #84 中对
\inserttitlegraphic的重定义，如果用户需要使用default的title page，会导致其在插入\titlepage时调用\usebeamertemplate{titlegraphic}，而此时\usebeamertemplate{titlegraphic}(default) 会调用\inserttitlegraphic然后调用\usebeamertemplate{titlegraphic}，从而导致循环调用。本 PR 将使用sjtutitlegraphic的 beamer template 来管理 SJTUBeamer “原生”的头图，并添加\setsjtutitlegraphic来初始化\titlegraphic。回退 #156 关于头图为空的判定，因为现在应当使用
\inserttitlegraphic是否为空来判定。