Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't update IMA due to gnosis safe api url change #1542

Open
1 task
DimaStebaev opened this issue Aug 2, 2023 · 6 comments · Fixed by #1536, #1552 or #1657
Open
1 task

Can't update IMA due to gnosis safe api url change #1542

DimaStebaev opened this issue Aug 2, 2023 · 6 comments · Fixed by #1536, #1552 or #1657
Assignees
Labels
bug Something isn't working
Milestone

Comments

@DimaStebaev
Copy link
Contributor

DimaStebaev commented Aug 2, 2023

Tasks

  1. bug
    yavrsky
@DimaStebaev DimaStebaev self-assigned this Aug 2, 2023
@DimaStebaev DimaStebaev linked a pull request Aug 2, 2023 that will close this issue
@DimaStebaev DimaStebaev linked a pull request Aug 14, 2023 that will close this issue
@DmytroNazarenko
Copy link
Contributor

IMA: 2.0.0-beta.8

@OleksanderSalamatov
Copy link

OleksanderSalamatov commented Nov 14, 2023

Gnosis updated their sdk from safe-core-sdk to protocol-kit. In IMA upgrade script we still use old SDK, which causes problems with upgrade procedure via multisig. We should update dependencies to use protocol-kit instead of deprecated safe-core-sdk.

#1638

@EvgeniyZZ EvgeniyZZ reopened this Nov 21, 2023
@EvgeniyZZ
Copy link

@DmytroNazarenko Triage

@PolinaKiporenko PolinaKiporenko added this to the SKALE 2.3 milestone Nov 22, 2023
@DmytroNazarenko
Copy link
Contributor

Moved to 2.4 as 2.3 does not contain IMA mainnet contracts changes

@PolinaKiporenko PolinaKiporenko modified the milestones: SKALE 2.3, SKALE 2.4 Dec 11, 2023
@DmytroNazarenko DmytroNazarenko added the bug Something isn't working label Dec 15, 2023
@yavrsky yavrsky linked a pull request Jan 12, 2024 that will close this issue
@PolinaKiporenko
Copy link

ima: 2.1.0-beta.2

@OleksanderSalamatov
Copy link

Contracts update via multisig still not working "out of the box" for modern testnets e.g. Sepolia and Holesky

IMA: 2.1.0-beta.2

Error log:

Owner is a contract
Using Gnosis Safe
Error: Can't get safe-transaction url at network with chainId = 11155111
    at getSafeTransactionUrl (/root/Workspace/IMA/proxy/node_modules/@skalenetwork/upgrade-tools/dist/src/gnosis-safe.js:109:15)
    at /root/Workspace/IMA/proxy/node_modules/@skalenetwork/upgrade-tools/dist/src/gnosis-safe.js:98:27
    at Generator.next (<anonymous>)
    at fulfilled (/root/Workspace/IMA/proxy/node_modules/@skalenetwork/upgrade-tools/dist/src/gnosis-safe.js:5:58)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)

Solution:
Add networks and api urls to gnosis-safe.js/gnosis-safe.ts like this (example for Sepolia network):

(function (Network) {
    Network[Network["MAINNET"] = 1] = "MAINNET";
    Network[Network["GOERLI"] = 5] = "GOERLI";
    Network[Network["GANACHE"] = 1337] = "GANACHE";
    Network[Network["HARDHAT"] = 31337] = "HARDHAT";
    Network[Network["SEPOLIA"] = 11155111] = "SEPOLIA";
})(Network || (Network = {}));
// constants
const URLS = {
    safe_transaction: {
        [Network.MAINNET]: "https://safe-transaction-mainnet.safe.global",
        [Network.GOERLI]: "https://safe-transaction-goerli.safe.global",
        [Network.SEPOLIA]: "https://safe-transaction-sepolia.safe.global"
    }   
};

For the holesky we should consider using 3rd party api url, as gnosis-safe do not provide their own api for this network, maybe we can use this project: https://holesky-safe.protofire.io/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Ready For Pickup
6 participants