Update upgrade-tools #1536
Merged
Update upgrade-tools #1536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## beta #1536 +/- ##
==========================================
- Coverage 90.16% 85.79% -4.38%
==========================================
Files 26 26
Lines 1322 1464 +142
Branches 348 401 +53
==========================================
+ Hits 1192 1256 +64
Misses 33 33
- Partials 97 175 +78 |
DimaStebaev
requested review from
payvint,
sergiy-skalelabs and
kladkogex
as code owners
sergiy-skalelabs
approved these changes
Aug 7, 2023
DmytroNazarenko
approved these changes
Aug 7, 2023
payvint
reviewed
Aug 9, 2023
| export function getProxyMainnet(contractName: string) { | ||
| const defaultFilePath = "../data/proxyMainnet.json"; | ||
| const jsonData = require(defaultFilePath); | ||
| async function getProxyMainnet(contractName: string) { |
There was a problem hiding this comment.
Yes. readFile is an async call.
payvint
reviewed
Aug 9, 2023
payvint
reviewed
Aug 9, 2023
| @@ -156,7 +156,7 @@ async function main() { | |||
| }; | |||
| await keyStorage.setBlsCommonPublicKeyForSchain( ethers.utils.solidityKeccak256(['string'], [schainName]), BLSPublicKey ); | |||
| console.log("Set common public key in KeyStorage contract", keyStorage.address, "\n"); | |||
| await wallets.rechargeSchainWallet( web3.utils.soliditySha3( schainName ), { value: "10000000000000000000" } ); // originally it was 1000000000000000000 = 1ETH | |||
| await wallets.rechargeSchainWallet( ethers.utils.solidityKeccak256( ["string"], [schainName] ), { value: "10000000000000000000" } ); // originally it was 1000000000000000000 = 1ETH | |||
There was a problem hiding this comment.
Maybe using stringKeccak256 from helper?
payvint
reviewed
Aug 9, 2023
| CommunityPool | ||
| } from "../typechain"; | ||
| import { stringFromHex, stringValue, getPublicKey } from "./utils/helper"; | ||
| import { stringKeccak256, getBalance, getPublicKey } from "./utils/helper"; |
There was a problem hiding this comment.
Is getBalance used somewhere?
There was a problem hiding this comment.
Yes.
At line # 76 for example.
payvint
reviewed
Aug 9, 2023
proxy/test/TokenManagerERC20.ts
Outdated
| @@ -64,7 +64,7 @@ describe("TokenManagerERC20", () => { | |||
| const schainId = ethers.utils.solidityKeccak256(["string"], [schainName]); | |||
There was a problem hiding this comment.
Use solidityKeccak256 from helper?
ity. |
payvint
approved these changes
Aug 11, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.