-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update upgrade-tools #1536
Update upgrade-tools #1536
Conversation
Codecov Report
@@ Coverage Diff @@
## beta #1536 +/- ##
==========================================
- Coverage 90.16% 85.79% -4.38%
==========================================
Files 26 26
Lines 1322 1464 +142
Branches 348 401 +53
==========================================
+ Hits 1192 1256 +64
Misses 33 33
- Partials 97 175 +78 |
export function getProxyMainnet(contractName: string) { | ||
const defaultFilePath = "../data/proxyMainnet.json"; | ||
const jsonData = require(defaultFilePath); | ||
async function getProxyMainnet(contractName: string) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
async??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. readFile
is an async call.
@@ -156,7 +156,7 @@ async function main() { | |||
}; | |||
await keyStorage.setBlsCommonPublicKeyForSchain( ethers.utils.solidityKeccak256(['string'], [schainName]), BLSPublicKey ); | |||
console.log("Set common public key in KeyStorage contract", keyStorage.address, "\n"); | |||
await wallets.rechargeSchainWallet( web3.utils.soliditySha3( schainName ), { value: "10000000000000000000" } ); // originally it was 1000000000000000000 = 1ETH | |||
await wallets.rechargeSchainWallet( ethers.utils.solidityKeccak256( ["string"], [schainName] ), { value: "10000000000000000000" } ); // originally it was 1000000000000000000 = 1ETH |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe using stringKeccak256 from helper?
CommunityPool | ||
} from "../typechain"; | ||
import { stringFromHex, stringValue, getPublicKey } from "./utils/helper"; | ||
import { stringKeccak256, getBalance, getPublicKey } from "./utils/helper"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is getBalance used somewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes.
At line # 76 for example.
proxy/test/TokenManagerERC20.ts
Outdated
@@ -64,7 +64,7 @@ describe("TokenManagerERC20", () => { | |||
const schainId = ethers.utils.solidityKeccak256(["string"], [schainName]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use solidityKeccak256 from helper?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks solid
ity. |
No description provided.