Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't update manager due to gnosis safe api url change #981

Closed
OleksanderSalamatov opened this issue Jul 20, 2023 · 2 comments · Fixed by #982, skalenetwork/IMA#1536, #983 or #986
Closed

Can't update manager due to gnosis safe api url change #981

OleksanderSalamatov opened this issue Jul 20, 2023 · 2 comments · Fixed by #982, skalenetwork/IMA#1536, #983 or #986
Assignees
Labels
bug Something isn't working release:2.2

Comments

@OleksanderSalamatov
Copy link

Upgrade script is working correctly, but can not connect to gnosis api due to recent gnosis safe api url change
Potentially same issue are applicable to IMA
Release candidates should be remade for correct upgrade of mainnet contracts

Upgrade: 1.9.3-beta.4 -> 1.9.4-beta.0
Log of manager upgrade:

Generating typings for: 0 artifacts in dir: typechain-types for target: ethers-v5
Successfully generated 3 typings!
Successfully generated 7 typings for external artifacts!
Will mark updated version as 1.9.4-beta.0
Prepare upgrade of ContractManager
Contract ContractManager is up to date
Prepare upgrade of DelegationController
Contract DelegationController is up to date
Prepare upgrade of DelegationPeriodManager
Contract DelegationPeriodManager is up to date
Prepare upgrade of Distributor
Contract Distributor is up to date
Prepare upgrade of Punisher
Contract Punisher is up to date
Prepare upgrade of SlashingTable
Contract SlashingTable is up to date
Prepare upgrade of TimeHelpers
Contract TimeHelpers is up to date
Prepare upgrade of TokenState
Contract TokenState is up to date
Prepare upgrade of ValidatorService
Contract ValidatorService is up to date
Prepare upgrade of ConstantsHolder
Contract ConstantsHolder is up to date
Prepare upgrade of Nodes
Warning: Potentially unsafe deployment of Nodes

   You are using the `unsafeAllow.external-library-linking` flag to include external libraries.
   Make sure you have manually checked that the linked libraries are upgrade safe.

Nothing to compile
Generating typings for: 0 artifacts in dir: typechain-types for target: ethers-v5
Successfully generated 3 typings!
Successfully generated 7 typings for external artifacts!
Compiling 1 file with 0.8.17
Successfully submitted source code for contract
contracts/Nodes.sol:Nodes at 0xF9C383C95DE7D295343b7956477111C94Ed55809
for verification on the block explorer. Waiting for verification result...

Successfully verified contract Nodes on Etherscan.
https://goerli.etherscan.io/address/0xF9C383C95DE7D295343b7956477111C94Ed55809#code
Prepare upgrade of NodeRotation
Compiling 105 files with 0.8.17
Generating typings for: 120 artifacts in dir: typechain-types for target: ethers-v5
Successfully generated 199 typings!
Successfully generated 7 typings for external artifacts!
Solidity compilation finished successfully
Compiling 1 file with 0.8.17
Successfully submitted source code for contract
contracts/NodeRotation.sol:NodeRotation at 0x5FA723822B283955AD7028f4F8bff179e91a00d3
for verification on the block explorer. Waiting for verification result...

Successfully verified contract NodeRotation on Etherscan.
https://goerli.etherscan.io/address/0x5FA723822B283955AD7028f4F8bff179e91a00d3#code
Prepare upgrade of SchainsInternal
Contract SchainsInternal is up to date
Prepare upgrade of Schains
Contract Schains is up to date
Prepare upgrade of Decryption
Contract Decryption is up to date
Prepare upgrade of ECDH
Contract ECDH is up to date
Prepare upgrade of KeyStorage
Contract KeyStorage is up to date
Prepare upgrade of SkaleDKG
Warning: Potentially unsafe deployment of SkaleDKG

   You are using the `unsafeAllow.external-library-linking` flag to include external libraries.
   Make sure you have manually checked that the linked libraries are upgrade safe.

Compiling 105 files with 0.8.17
Generating typings for: 120 artifacts in dir: typechain-types for target: ethers-v5
Successfully generated 199 typings!
Successfully generated 7 typings for external artifacts!
Solidity compilation finished successfully
Compiling 1 file with 0.8.17
Successfully submitted source code for contract
contracts/SkaleDKG.sol:SkaleDKG at 0xF316989c412787Cdd9435883DC653EE3291f1831
for verification on the block explorer. Waiting for verification result...

Successfully verified contract SkaleDKG on Etherscan.
https://goerli.etherscan.io/address/0xF316989c412787Cdd9435883DC653EE3291f1831#code
Prepare upgrade of SkaleVerifier
Contract SkaleVerifier is up to date
Prepare upgrade of SkaleManager
Contract SkaleManager is up to date
Prepare upgrade of Pricing
Contract Pricing is up to date
Prepare upgrade of BountyV2
Contract BountyV2 is up to date
Prepare upgrade of Wallets
Contract Wallets is up to date
Prepare upgrade of SyncManager
Contract SyncManager is up to date
Prepare transaction to upgrade Nodes at 0x9E0A1C41E922b826A38E27eDb0359830c7B43F41 to 0xF9C383C95DE7D295343b7956477111C94Ed55809
Prepare transaction to upgrade NodeRotation at 0x9f90287f4cae4A51c6A0ed0e3e9d62f1cb4B7772 to 0x5FA723822B283955AD7028f4F8bff179e91a00d3
Prepare transaction to upgrade SkaleDKG at 0x69E2C9576B36c8d7938Ba45a1C909B67EC53048E to 0xF316989c412787Cdd9435883DC653EE3291f1831
Owner is a contract
Using Gnosis Safe
AxiosError: getaddrinfo ENOTFOUND safe-transaction.goerli.gnosis.io
   at GetAddrInfoReqWrap.onlookup [as oncomplete] (dns.js:71:26) {
 hostname: 'safe-transaction.goerli.gnosis.io',
 syscall: 'getaddrinfo',
 code: 'ENOTFOUND',
 errno: -3008,
 config: {
   transitional: {
     silentJSONParsing: true,
     forcedJSONParsing: true,
     clarifyTimeoutError: false
   },
   adapter: [Function: httpAdapter],
   transformRequest: [ [Function: transformRequest] ],
   transformResponse: [ [Function: transformResponse] ],
   timeout: 0,
   xsrfCookieName: 'XSRF-TOKEN',
   xsrfHeaderName: 'X-XSRF-TOKEN',
   maxContentLength: -1,
   maxBodyLength: -1,
   env: { FormData: [Function] },
   validateStatus: [Function: validateStatus],
   headers: {
     Accept: 'application/json, text/plain, */*',
     'User-Agent': 'axios/0.27.2'
   },
   method: 'get',
   url: 'https://safe-transaction.goerli.gnosis.io/api/v1/safes/0xeE4D4Af96296e556e376e844F7ED38c042a5F0F0/',
   data: undefined
 },
 request: <ref *1> Writable {
   _writableState: WritableState {
     objectMode: false,
     highWaterMark: 16384,
     finalCalled: false,
     needDrain: false,
     ending: false,
     ended: false,
     finished: false,
     destroyed: false,
     decodeStrings: true,
     defaultEncoding: 'utf8',
     length: 0,
     writing: false,
     corked: 0,
     sync: true,
     bufferProcessing: false,
     onwrite: [Function: bound onwrite],
     writecb: null,
     writelen: 0,
     afterWriteTickInfo: null,
     buffered: [],
     bufferedIndex: 0,
     allBuffers: true,
     allNoop: true,
     pendingcb: 0,
     prefinished: false,
     errorEmitted: false,
     emitClose: true,
     autoDestroy: true,
     errored: null,
     closed: false
   },
   _events: [Object: null prototype] {
     response: [Function: handleResponse],
     error: [Function: handleRequestError],
     socket: [Function: handleRequestSocket]
   },
   _eventsCount: 3,
   _maxListeners: undefined,
   _options: {
     maxRedirects: 21,
     maxBodyLength: 10485760,
     protocol: 'https:',
     path: '/api/v1/safes/0xeE4D4Af96296e556e376e844F7ED38c042a5F0F0/',
     method: 'GET',
     headers: [Object],
     agent: undefined,
     agents: [Object],
     auth: undefined,
     hostname: 'safe-transaction.goerli.gnosis.io',
     port: null,
     nativeProtocols: [Object],
     pathname: '/api/v1/safes/0xeE4D4Af96296e556e376e844F7ED38c042a5F0F0/'
   },
   _ended: true,
   _ending: true,
   _redirectCount: 0,
   _redirects: [],
   _requestBodyLength: 0,
   _requestBodyBuffers: [],
   _onNativeResponse: [Function (anonymous)],
   _currentRequest: ClientRequest {
     _events: [Object: null prototype],
     _eventsCount: 7,
     _maxListeners: undefined,
     outputData: [],
     outputSize: 0,
     writable: true,
     destroyed: false,
     _last: true,
     chunkedEncoding: false,
     shouldKeepAlive: false,
     _defaultKeepAlive: true,
     useChunkedEncodingByDefault: false,
     sendDate: false,
     _removedConnection: false,
     _removedContLen: false,
     _removedTE: false,
     _contentLength: 0,
     _hasBody: true,
     _trailer: '',
     finished: true,
     _headerSent: true,
     socket: [TLSSocket],
     _header: 'GET /api/v1/safes/0xeE4D4Af96296e556e376e844F7ED38c042a5F0F0/ HTTP/1.1\r\n' +
       'Accept: application/json, text/plain, */*\r\n' +
       'User-Agent: axios/0.27.2\r\n' +
       'Host: safe-transaction.goerli.gnosis.io\r\n' +
       'Connection: close\r\n' +
       '\r\n',
     _keepAliveTimeout: 0,
     _onPendingData: [Function: noopPendingOutput],
     agent: [Agent],
     socketPath: undefined,
     method: 'GET',
     maxHeaderSize: undefined,
     insecureHTTPParser: undefined,
     path: '/api/v1/safes/0xeE4D4Af96296e556e376e844F7ED38c042a5F0F0/',
     _ended: false,
     res: null,
     aborted: false,
     timeoutCb: null,
     upgradeOrConnect: false,
     parser: null,
     maxHeadersCount: null,
     reusedSocket: false,
     host: 'safe-transaction.goerli.gnosis.io',
     protocol: 'https:',
     _redirectable: [Circular *1],
     [Symbol(kCapture)]: false,
     [Symbol(kNeedDrain)]: false,
     [Symbol(corked)]: 0,
     [Symbol(kOutHeaders)]: [Object: null prototype]
   },
   _currentUrl: 'https://safe-transaction.goerli.gnosis.io/api/v1/safes/0xeE4D4Af96296e556e376e844F7ED38c042a5F0F0/',
   [Symbol(kCapture)]: false
 }
}
@OleksanderSalamatov OleksanderSalamatov added the bug Something isn't working label Jul 20, 2023
This was linked to pull requests Jul 24, 2023
@DimaStebaev DimaStebaev linked a pull request Aug 1, 2023 that will close this issue
@DmytroNazarenko
Copy link
Contributor

skale-manager: 1.9.4-beta.2

@OleksanderSalamatov
Copy link
Author

Upgrade from multisig verified to be woking
1.9.3-beta.4 -> 1.9.4-beta.2
1.9.4-beta.2 -> 1.9.4-beta.3

During second upgrade procedure encountered issue with multisig nonce being +2 related to last tx, not +1.
Seems to be Safe SDK bug unrelated to skale-manager itself, will create ticket if issue will be reproduced in the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working release:2.2
Projects
Archived in project
4 participants