Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEXT: Update Svelte/React packages to utilize PNPM Catalogs for version syncing #2807

Closed
endigo9740 opened this issue Aug 13, 2024 · 1 comment
Assignees
Labels
administration Items related to the project but outside the code.
Milestone

Comments

@endigo9740
Copy link
Contributor

endigo9740 commented Aug 13, 2024

Following our recent integration of Zag.js, we've learned that each individual Zag component is installed as it's own separate package per framework. For example:

"@zag-js/accordion": "^0.65.0",
"@zag-js/avatar": "^0.65.0",
"@zag-js/progress": "^0.65.0",
"@zag-js/radio-group": "^0.65.0",
"@zag-js/rating-group": "^0.65.0",
"@zag-js/react": "^0.65.0",
"@zag-js/switch": "^0.65.0",
"@zag-js/tabs": "^0.65.0",

These versions must stay in sync to ensure these components remain operational and type data resolves as expected.

@Hugos68 and @AdrianGonz97 have determined a potential solution for this using PNPM catalogs. This will provide a variable in place of the version number that we can control within the monorepo and ensure these remain in sync.

If necessary we should update any related contributor documentation around this. Specifying a minimum version of PNPM to use, etc.

Goals:

  • Implement PNPM catalogs for Zag in our Svelte/React packages
  • Ensure all Skeleton team members make local updates (update PNPM, etc)
  • Document requirements for contributors
@endigo9740 endigo9740 added the administration Items related to the project but outside the code. label Aug 13, 2024
@endigo9740 endigo9740 added this to the v3.0 (Next) milestone Aug 13, 2024
@endigo9740
Copy link
Contributor Author

endigo9740 commented Aug 13, 2024

@Hugos68 @AdrianGonz97 feel free to correct me on any of this if I've mispoken!

@AdrianGonz97 AdrianGonz97 changed the title NEXT: Update Svelte/React packages to utilize PNPM Categories for version syncing NEXT: Update Svelte/React packages to utilize PNPM Catalogs for version syncing Aug 13, 2024
@endigo9740 endigo9740 changed the title NEXT: Update Svelte/React packages to utilize PNPM Catalogs for version syncing NEXT: Update Svelte/React packages to utilize PNPM Categories for version syncing Aug 13, 2024
@endigo9740 endigo9740 changed the title NEXT: Update Svelte/React packages to utilize PNPM Categories for version syncing NEXT: Update Svelte/React packages to utilize PNPM Catalogs for version syncing Aug 13, 2024
@endigo9740 endigo9740 pinned this issue Aug 13, 2024
@endigo9740 endigo9740 unpinned this issue Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
administration Items related to the project but outside the code.
Projects
None yet
Development

No branches or pull requests

3 participants