-
-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Use catalogs
to manage versions of common dependencies
#2812
Chore: Use catalogs
to manage versions of common dependencies
#2812
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@Hugos68 is attempting to deploy a commit to the Skeleton Labs Team on Vercel. A member of the Team first needs to authorize it. |
catalogs
to manage versions of common dependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we'll also want to update the engines
and packageManager
field in the root package.json
to use 9.6.0
or higher (the latest is 9.7.1
).
…keleton into chore/catalog-versions
…keleton into chore/catalog-versions
this looks good now, but we'll first have to resolve why vercel's deployment is failing before we merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removing the engines
field did the trick. this is good to go!
Linked Issue
Closes #2807
Description
Uses a monorepo root
catalog
to define versions for every package so it's easier to upgrade, manage, etc.See: https://pnpm.io/catalogs
Changsets
Instructions: Changesets automate our changelog. If you modify files in
/packages
, runpnpm changeset
in the root of the monorepo, follow the prompts, then commit the markdown file. Changes that add features should beminor
while chores and bugfixes should bepatch
. Please prefix the changeset message withfeat:
,bugfix:
orchore:
.Checklist
Please read and apply all contribution requirements.
dev
branch (NEVERmaster
)docs/
,feat/
,chore/
,bugfix/
pnpm ci:check
pnpm format
pnpm test