Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEXT: Update components to use Zag.js #2778

Merged
merged 121 commits into from
Aug 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
121 commits
Select commit Hold shift + click to select a range
bd9796f
stuff
Hugos68 Jul 23, 2024
3f0caae
test
Hugos68 Jul 23, 2024
b51c51f
Fixed animations
Hugos68 Jul 23, 2024
2c69a66
Merge latest
endigo9740 Jul 24, 2024
29c6bc7
React Avatar updated to Zag
endigo9740 Jul 24, 2024
d77d164
Adjust React Avatar
endigo9740 Jul 24, 2024
257a678
...
endigo9740 Jul 24, 2024
e19ce73
Svelte Avatar updated to Zag
endigo9740 Jul 25, 2024
437644c
Update Avatar docs, add Fallback example
endigo9740 Jul 25, 2024
320b127
Schema updates for React components
endigo9740 Jul 25, 2024
ce2b139
Remove Accordion inspect
endigo9740 Jul 25, 2024
ec98d0a
React Switch updated to use Zag
endigo9740 Jul 25, 2024
6ed1be0
Feedback adjustments
endigo9740 Jul 26, 2024
5fb74f6
Svelte Switch component updated to Zag
endigo9740 Jul 26, 2024
3f191b0
Switch docs and tests updated
endigo9740 Jul 26, 2024
0ef423a
Implement useId util for UUIDs
endigo9740 Jul 26, 2024
f7b9d88
Remove title attribute for Nav Tile Svelte examples
endigo9740 Jul 26, 2024
dc02cce
Revsert
endigo9740 Jul 26, 2024
6b89d8b
Accordion minor refactor
endigo9740 Jul 26, 2024
075e625
Added back a11y heading requirement :newspaper: chris
Hugos68 Jul 26, 2024
2f3fa45
Cleanup
Hugos68 Jul 27, 2024
7e80f4c
Patched accordion once again
Hugos68 Jul 28, 2024
c232204
types
Hugos68 Jul 28, 2024
db009c0
React accordion done
Hugos68 Jul 28, 2024
0580bcf
stuff
Hugos68 Jul 28, 2024
905f9e0
cleanup
Hugos68 Jul 28, 2024
0db7b0e
yes
Hugos68 Jul 28, 2024
20635b1
test
Hugos68 Jul 28, 2024
52aef00
Modify React package noop path to resolve Astro bug
endigo9740 Jul 29, 2024
9237489
Update React Accordion example to use value prop
endigo9740 Jul 29, 2024
3b1648b
Merge latest
endigo9740 Jul 30, 2024
6d24403
Resolve React check issue
endigo9740 Jul 30, 2024
011d9f5
react accordion docs
Hugos68 Jul 30, 2024
aa78a4a
Fixed missing schema import
Hugos68 Jul 31, 2024
e50ced5
Added progress svelte
Hugos68 Jul 31, 2024
e08d3bd
fix
Hugos68 Jul 31, 2024
9f2a385
Progress Ring migrated to Zag
endigo9740 Jul 31, 2024
9a01355
Fixed versioning, simplified
Hugos68 Jul 31, 2024
3efe997
feedback
Hugos68 Aug 1, 2024
c07f514
Progress Ring style attribute inlined
endigo9740 Aug 1, 2024
9622e72
Svelte Progress Ring updated to Zag
endigo9740 Aug 1, 2024
87f4f89
Remove extra quote
endigo9740 Aug 1, 2024
363780d
React Progress Ring animation working
endigo9740 Aug 2, 2024
29c848a
Svelte Progress Ring animation added
endigo9740 Aug 2, 2024
36f3f77
Progress Ring docs updated
endigo9740 Aug 2, 2024
1359476
Update toggle text for lightswitch
endigo9740 Aug 2, 2024
9a54b0d
Firefox style fix for Progress Ring examples
endigo9740 Aug 2, 2024
b22b56d
Added react progress
Hugos68 Aug 3, 2024
96ea3cb
type
Hugos68 Aug 3, 2024
4b48382
JSDoc
Hugos68 Aug 3, 2024
e7574fb
Added svelte rating
Hugos68 Aug 3, 2024
3bfea7b
playground refinements
Hugos68 Aug 3, 2024
1c7728a
React Segment Control updated with Zag
endigo9740 Aug 6, 2024
865e0b3
ratings stuff
Hugos68 Aug 6, 2024
1a7d6df
Merge branch 'feat/zag-js-demo' of https://github.com/Hugos68/skeleto…
Hugos68 Aug 6, 2024
b33d901
stuff
Hugos68 Aug 7, 2024
5b80321
Added build in SVG's
Hugos68 Aug 7, 2024
6b52cef
Moved to snippets.ts
Hugos68 Aug 7, 2024
839049b
React segment feedback and general improvements
endigo9740 Aug 7, 2024
4c996f8
Merge branch 'feat/zag-js-demo' of https://github.com/Hugos68/skeleto…
endigo9740 Aug 7, 2024
97fc871
Update Zag deps, implement Svelte Seg Control component
endigo9740 Aug 7, 2024
87b2e84
Fix Svelte sandbox orientation
endigo9740 Aug 7, 2024
3084c91
Minor adjustment to machine property order
endigo9740 Aug 7, 2024
7c34395
Seg control docs updated
endigo9740 Aug 7, 2024
d591738
Update unit tests
endigo9740 Aug 7, 2024
8d655b9
Disable e2e tests for Svelte package
endigo9740 Aug 7, 2024
2a32919
Moved to zagprops for segment item, allows disabled now
Hugos68 Aug 7, 2024
ff2f3bf
react rating
Hugos68 Aug 8, 2024
3985e22
Ported react rating
Hugos68 Aug 8, 2024
7daa18f
Seg Control disabled and readme implemented
endigo9740 Aug 8, 2024
d6c3d92
Update Seg Control docs
endigo9740 Aug 8, 2024
39ff19f
Update Ratings sandbox docs
endigo9740 Aug 8, 2024
2311e5b
Fix Segment shared state bug, minor Ratings prop updates
endigo9740 Aug 8, 2024
660dd35
:rocket: Rating done, hopefully ready to merge :pray:
Hugos68 Aug 9, 2024
00b2227
stuff
Hugos68 Aug 9, 2024
64009b3
Fixed comment
Hugos68 Aug 9, 2024
d4fa739
Ratings review updates
endigo9740 Aug 9, 2024
cc231d3
React Tabs refactor to Zag
endigo9740 Aug 9, 2024
1f32a3d
RTL prop added
endigo9740 Aug 9, 2024
b2a4c97
UPDATED DEPS
Hugos68 Aug 9, 2024
3ab2a4e
Merge branch 'feat/zag-js-demo' of https://github.com/Hugos68/skeleto…
Hugos68 Aug 9, 2024
eb9e2d9
fix classes
Hugos68 Aug 9, 2024
2206b8b
Yay build succeeded
Hugos68 Aug 9, 2024
a7ff50c
Fixed segment control bugs, removed unneccesary type that wasn't used…
Hugos68 Aug 10, 2024
442cd59
Updated svelte deps
Hugos68 Aug 10, 2024
52373f2
update lockfile
Hugos68 Aug 10, 2024
50a5d00
stuff
Hugos68 Aug 10, 2024
4d1cdb7
Rating docs
Hugos68 Aug 11, 2024
10ed99d
fixed key issue for sandbox page
Hugos68 Aug 11, 2024
30b42ff
Refactor Progress components to follow style prop patterns, account f…
endigo9740 Aug 11, 2024
3c5d3fc
Ratings examples updated
endigo9740 Aug 11, 2024
1b44965
Fixed animation classes
Hugos68 Aug 11, 2024
6af3984
Fix example names
Hugos68 Aug 11, 2024
34107f6
Added custom icon
Hugos68 Aug 11, 2024
1bde8d3
Tab docs and examples updated
endigo9740 Aug 11, 2024
7649f76
Format
endigo9740 Aug 11, 2024
c9ee1a4
Merge branch 'feat/zag-js-demo' of https://github.com/Hugos68/skeleto…
endigo9740 Aug 11, 2024
5d46320
Restore basic Tabs unit test
endigo9740 Aug 11, 2024
b318deb
fix
Hugos68 Aug 11, 2024
8fe450d
Merge branch 'feat/zag-js-demo' of https://github.com/Hugos68/skeleto…
Hugos68 Aug 11, 2024
4c160a4
fixed tsx lang issue
Hugos68 Aug 12, 2024
f557238
variable name change in line with others
Hugos68 Aug 12, 2024
d282ae7
Update Ratings docs, React Ratings examples now persist selection
endigo9740 Aug 12, 2024
9cd40c2
Segment Control docs updated
endigo9740 Aug 12, 2024
c48e86d
Switch list docs improved, Svelte bindable fixed
endigo9740 Aug 12, 2024
3951691
Improve tabs examples
endigo9740 Aug 12, 2024
eaf5ac3
Update React Progress component to use Figure tag
endigo9740 Aug 12, 2024
7515e03
Apply consistent use of data testid attributes
endigo9740 Aug 12, 2024
474fd66
Consistent use of Svelte at component comments
endigo9740 Aug 12, 2024
9210012
Consistent comments for Zag logic
endigo9740 Aug 12, 2024
649c91c
Unify Accordion API names, add missing style props
endigo9740 Aug 12, 2024
999c44c
Various Accordion doc and bug fixes
endigo9740 Aug 12, 2024
32d09e9
Fix Svelte Check switch component bug
endigo9740 Aug 12, 2024
eb7ff43
Fix Switch change event handler bug
endigo9740 Aug 12, 2024
5e9da4c
Formatting pass
endigo9740 Aug 12, 2024
cc75c1c
Disabled broken test cases
endigo9740 Aug 12, 2024
036ac55
Updated React schema
endigo9740 Aug 12, 2024
6c1b1b9
Update package lock file
endigo9740 Aug 12, 2024
7d113c0
Minor doc app README update
endigo9740 Aug 12, 2024
2231fe2
Added changeset
endigo9740 Aug 12, 2024
62adb69
Fix typo in React Accordion types JSdoc
endigo9740 Aug 13, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/sixty-jeans-drop.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"@skeletonlabs/skeleton-svelte": minor
"@skeletonlabs/skeleton-react": minor
"@skeletonlabs/skeleton": patch
---

All Skeleton components have been updated to integrate Zag.js. This contains a number of breaking component API changes. Updates all documentation. And includes new CSS animations in the Tailwind plugin. ([More Information](https://github.com/skeletonlabs/skeleton/discussions/2784))
4 changes: 3 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,14 @@
"check": "pnpm -r check",
"clean": "node ./scripts/rimraf.js",
"dev": "pnpm -F next.skeleton.dev dev",
"dev:svelte": "pnpm -F @skeletonlabs/skeleton-svelte dev",
"dev:react": "pnpm -F @skeletonlabs/skeleton-react dev",
"format": "prettier -w .",
"format:check": "prettier . --check",
"lint": "eslint . --ignore-path .gitignore",
"lint:fix": "eslint . --fix --ignore-path .gitignore",
"postinstall": "pnpm -r sync",
"test": "pnpm -F '@skeletonlabs/*' test"
"test": "pnpm -F \"@skeletonlabs/*\" test"
},
"devDependencies": {
"@changesets/cli": "^2.26.1",
Expand Down
11 changes: 8 additions & 3 deletions packages/skeleton-react/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,14 @@
"@types/react": "^18.3.3",
"@types/react-dom": "^18.3.0",
"@vitejs/plugin-react": "^4.3.1",
"@zag-js/accordion": "^0.65.0",
"@zag-js/avatar": "^0.65.0",
"@zag-js/progress": "^0.65.0",
"@zag-js/radio-group": "^0.65.0",
"@zag-js/rating-group": "^0.65.0",
"@zag-js/react": "^0.65.0",
"@zag-js/switch": "^0.65.0",
"@zag-js/tabs": "^0.65.0",
"autoprefixer": "^10.4.19",
"jsdom": "^24.1.1",
"lucide-react": "^0.341.0",
Expand All @@ -64,8 +72,5 @@
"vite-plugin-remix-router": "^2.0.0",
"vite-plugin-tw-plugin-watcher": "workspace:*",
"vitest": "^1.6.0"
},
"peerDependencies": {
"framer-motion": "^11.0.24"
}
}
29 changes: 13 additions & 16 deletions packages/skeleton-react/src/App.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -20,19 +20,16 @@ function App() {
skeleton-react
</a>
<hr className="hr" />
{/* eslint-disable-next-line jsx-a11y/label-has-associated-control */}
<label className="label flex items-center justify-between gap-4">
<p>Set Mode</p>
<Switch
id="mode"
name="mode"
stateActive="bg-surface-200"
checked={lightswitch}
onChange={onModeChange}
inactiveChild={<IconMoon size="14" />}
activeChild={<IconSun size="14" />}
/>
</label>
<Switch
name="mode"
controlActive="bg-surface-200"
checked={lightswitch}
onCheckedChange={onModeChange}
inactiveChild={<IconMoon size="14" />}
activeChild={<IconSun size="14" />}
>
<p>Toggle Mode</p>
</Switch>
<hr className="hr" />
{/* Components */}
<div className="space-y-8">
Expand All @@ -50,6 +47,9 @@ function App() {
<a className="anchor" href="/components/navigation">
Navigation
</a>
<a className="anchor" href="/components/ratings">
Ratings
</a>
<a className="anchor" href="/components/progress">
Progress
</a>
Expand All @@ -65,9 +65,6 @@ function App() {
<a className="anchor" href="/components/tabs">
Tabs
</a>
<a className="anchor" href="/components/ratings">
Ratings
</a>
</nav>
</div>
</div>
Expand Down
Loading
Loading