Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEXT: Resolve Unit Tests - Part 2 #2814

Merged
merged 8 commits into from
Aug 15, 2024
Merged

Conversation

endigo9740
Copy link
Contributor

@endigo9740 endigo9740 commented Aug 14, 2024

Linked Issue

#2805

Description

Updates and add tests after the recent Zag integration in #2778. See also:

Checklist

Please read and apply all contribution requirements.

  • Your branch should be prefixed with: docs/, feature/, chore/, bugfix/
  • Skeleton v3 contributions must target the next branch (NEVER dev or master)
  • Documentation should be updated to describe all relevant changes
  • Run pnpm check in the root of the monorepo
  • Run pnpm format in the root of the monorepo
  • Run pnpm lint in the root of the monorepo
  • Run pnpm test in the root of the monorepo
  • If you modify /package projects, please supply a Changeset

Changsets

View our documentation to learn more about Changesets. To create a Changeset:

  1. Navigate to the root of the monorepo in your terminal
  2. Run pnpm changeset and follow the prompts
  3. Commit and push the changeset before flagging your PR review for review.

@endigo9740 endigo9740 linked an issue Aug 14, 2024 that may be closed by this pull request
Copy link

changeset-bot bot commented Aug 14, 2024

🦋 Changeset detected

Latest commit: 7731f53

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@skeletonlabs/skeleton-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@endigo9740 endigo9740 changed the base branch from dev to next August 14, 2024 19:03
Copy link

vercel bot commented Aug 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
skeleton-docs ❌ Failed (Inspect) Aug 15, 2024 5:27pm
skeleton-next ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 15, 2024 5:27pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
skeleton-themes ⬜️ Ignored (Inspect) Visit Preview Aug 15, 2024 5:27pm

@endigo9740 endigo9740 changed the title NEXT: Resolve Unit Tests - Part 1 NEXT: Resolve Unit Tests - Part 2 Aug 14, 2024
@endigo9740 endigo9740 marked this pull request as draft August 14, 2024 19:05
Copy link
Contributor

@Hugos68 Hugos68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests all look good, just some cases that I was wondering if were needed.

@endigo9740 endigo9740 marked this pull request as ready for review August 15, 2024 17:24
@endigo9740 endigo9740 merged commit 8735a49 into next Aug 15, 2024
6 of 8 checks passed
@endigo9740 endigo9740 deleted the chore/fix-unit-tests-part-2 branch August 15, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NEXT: Resolve regressions in the component unit tests
2 participants