Keep composer cache in local directory #278
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andypost
approved these changes
Aug 31, 2020
|
Related #275 |
andypost
requested changes
Oct 9, 2020
| $(call php-0, kill -USR2 1) | ||
| $(call php, composer global require -o --update-no-dev --no-suggest "hirak/prestissimo:^0.3") | ||
|
|
||
| ## Install backend dependencies | ||
| back: | ||
| mkdir -p $(COMPOSER_HOME_CACHE) |
There was a problem hiding this comment.
any reason to duplicate provision goal here?
| @@ -146,6 +153,10 @@ ifdef MYSQL_DIR | |||
| @echo "Removing mysql data from $(MYSQL_DIR) ..." | |||
| docker run --rm --user 0:0 -v $(shell dirname $(MYSQL_DIR)):/mnt $(IMAGE_PHP) sh -c "rm -fr /mnt/`basename $(MYSQL_DIR)`" | |||
| endif | |||
| ifdef COMPOSER_HOME_CACHE | |||
There was a problem hiding this comment.
cache should not be cleared as it will be shared in CI
There was a problem hiding this comment.
Merged
andypost
force-pushed
the
composer_cache
branch
from
4745849
to
6eec60a
Compare
|
Closing it for #290 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To speed up site building we can keep composer cache in a local directory to be reused on future builds