Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP:MacOS shared folder config + cached option #38

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

WIP:MacOS shared folder config + cached option #38

wants to merge 4 commits into from

Conversation

iberdinsky-skilld
Copy link
Contributor

Two things done here:

  1. Changed shared folder location. Now it is env variable.
  2. Added macOS composer override file. To use cached option in volumes: https://docs.docker.com/docker-for-mac/osxfs-caching/

koskinpark
koskinpark reviewed Aug 3, 2017
View reviewed changes
src/docker/docker-compose.override.yml.default_mac Outdated
restart: always
networks:
- front

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here better to add then override for ports of mailhog too.
ports: - "8025:8025"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/skilld-labs/skilld-docker-container/pull/38/files#diff-1c5b1e66e569d11705ad352d61a06a7cR39

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep Macos needs portmapping, better to add it here

andypost
andypost requested changes Aug 3, 2017
View reviewed changes
Copy link
Contributor

@andypost andypost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found only 2 issues: naming of mysql var & expose port for mailhog

.env.default Outdated
@@ -6,3 +6,4 @@ SITE_NAME=Site name
COMPOSER_REQUIRE=solarium/solarium:3.6.*
PROJECT_INSTALL=
PHP_VERSION=7.1
SHARED_FOLDER=/dev/shm
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please give it better name a-la MYSQL_DATA_DIR

src/docker/docker-compose.override.yml.default_mac Outdated
restart: always
networks:
- front

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep Macos needs portmapping, better to add it here

@iberdinsky-skilld iberdinsky-skilld removed the request for review from andriyun May 29, 2018 05:32
@iberdinsky-skilld iberdinsky-skilld changed the title MacOS shared folder config + cached option WIP:MacOS shared folder config + cached option May 29, 2018
@gumanista
Copy link
Contributor

In .env file we have
COMPOSE_FILE=./docker/docker-compose.yml:./docker/docker-compose.override.yml
This may be used to add mac-specific config. So it can be docker-compose.mac.yml and link it as:
COMPOSE_FILE=./docker/docker-compose.yml:.docker/docker-compose.mac.yml:./docker/docker-compose.override.yml

also we have OS-detection and it can be used to handle os-specific tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koskinpark koskinpark koskinpark approved these changes

@andypost andypost andypost requested changes

@gaydabura gaydabura Awaiting requested review from gaydabura

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@iberdinsky-skilld @gumanista @andypost @koskinpark @finnsky