feat: switch typesense sorting to presets #1458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
zacjones93
commented
Jun 26, 2024
Comment on lines
+171
to
+181
| onChange={(e) => { | ||
| typesenseAdapter.updateConfiguration({ | ||
| ...typsenseAdapterConfig, | ||
| additionalSearchParameters: { | ||
| query_by: 'title,description,_tags,instructor_name,contributors', | ||
| preset: e.target.value, | ||
| }, | ||
| }) | ||
|
|
||
| refresh() | ||
| }} |
There was a problem hiding this comment.
where the magic happens. updates configuration and triggers a search
Comment on lines
+39
to
+41
| export const typesenseAdapter = typesenseInstantsearchAdapter() | ||
|
|
||
| const searchClient = typesenseAdapter.searchClient |
There was a problem hiding this comment.
need access to the typesenseAdapter to update configuration
| @@ -1,34 +1,29 @@ | |||
| import TypesenseInstantSearchAdapter from 'typesense-instantsearch-adapter' | |||
|
|
|||
| export const typsenseAdapterConfig = { | |||
There was a problem hiding this comment.
stuffed the config in an object to spread when we update presets
nicollguarnizo
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since migrating to TypeSense, whenever a user inputs a search or clicks a filter the url is populated by the sorting that we need to do for the content that makes sense.
e.g.
https://egghead.io/q?q=react&sortBy=content_production/sort/_eval([%20(type:playlist):4,%20(type:lesson):3,%20(type:podcast):2],%20(type:talk):1):desc,search_research_sort:asc,rank:ascThe first sorting function is particularly important as it rank sorts playlists to the top before other types of content.
The other way to do this is with presets but @Creeland and I were having a rough time actually setting a preset apart from initial load. Turns out that the TypeSense adapter has an
updateConfigurationfunction that we can call when we want to switch to a different preset as recommended here.I'm updating configuration in a select and calling instantsearches
refreshto trigger another search.