feat: Main Metrics Readme #278
Conversation
| @@ -114,7 +114,7 @@ var ( | |||
| // ----------------------Metrics Config----------------------- // | |||
| // ----------------------------------------------------------- // | |||
| Metrics: config.MetricsConfig{}, | |||
| UpdateInterval: 1500 * time.Millisecond, | |||
| UpdateInterval: 500 * time.Millisecond, | |||
There was a problem hiding this comment.
lowering the interval since dYdX block time is less than 1s
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #278 +/- ##
==========================================
- Coverage 62.19% 62.11% -0.08%
==========================================
Files 215 215
Lines 9495 9503 +8
==========================================
- Hits 5905 5903 -2
- Misses 3045 3055 +10
Partials 545 545 ☔ View full report in Codecov by Sentry. |
davidterpay
requested review from
nivasan1,
aljo242 and
Eric-Warehime
as code owners
| - ./config/dydx/oracle.json:/oracle/oracle.json | ||
| - ./config/dydx/market.json:/oracle/market.json |
There was a problem hiding this comment.
What is the docker-compose used in again? e2e tests?
There was a problem hiding this comment.
nothing, just running locally
|
|
||
| # Metrics | ||
|
|
||
| > **Definitions**: |
| This metric should be monotonically increasing for each (provider, market) pair. To verify that the rate of updates for each provider is as expected, you can run the following query in Prometheus: | ||
|
|
||
| ```promql | ||
| rate(side_car_health_check_provider_updates_total{provider="coinbase_api", success="true"}[5m]) |
There was a problem hiding this comment.
I'm a little confused about why the success rate over 5m is like 2/3 for all of the providers in these examples.
There was a problem hiding this comment.
I'm going to update so that we use the rate described above and follow up with explanations on the examples.
No description provided.