fix: compute gov addr after sdk.Config() changed
#316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beer-1
requested review from
davidterpay,
nivasan1,
aljo242 and
Eric-Warehime
as code owners
beer-1
changed the title
beer-1
changed the title
sdk.Config() changed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #316 +/- ##
==========================================
- Coverage 56.82% 56.80% -0.02%
==========================================
Files 227 227
Lines 10761 10761
==========================================
- Hits 6115 6113 -2
- Misses 4134 4136 +2
Partials 512 512 ☔ View full report in Codecov by Sentry. |
aljo242
approved these changes
Apr 5, 2024
…kip-mev#320) Bumps [github.com/cosmos/ibc-go/v8](https://github.com/cosmos/ibc-go) from 8.0.0 to 8.2.0. - [Release notes](https://github.com/cosmos/ibc-go/releases) - [Changelog](https://github.com/cosmos/ibc-go/blob/v8.2.0/CHANGELOG.md) - [Commits](cosmos/ibc-go@v8.0.0...v8.2.0) --- updated-dependencies: - dependency-name: github.com/cosmos/ibc-go/v8 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Alex Johnson <[email protected]> Co-authored-by: David Terpay <[email protected]>
…0.0 (skip-mev#327) Bumps [github.com/gagliardetto/solana-go](https://github.com/gagliardetto/solana-go) from 1.9.3 to 1.10.0. - [Release notes](https://github.com/gagliardetto/solana-go/releases) - [Changelog](https://github.com/gagliardetto/solana-go/blob/main/CHANGELOG.md) - [Commits](gagliardetto/solana-go@v1.9.3...v1.10.0) --- updated-dependencies: - dependency-name: github.com/gagliardetto/solana-go dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Alex Johnson <[email protected]> Co-authored-by: David Terpay <[email protected]>
Bumps [supplypike/setup-bin](https://github.com/supplypike/setup-bin) from 3 to 4. - [Release notes](https://github.com/supplypike/setup-bin/releases) - [Commits](supplypike/setup-bin@v3...v4) --- updated-dependencies: - dependency-name: supplypike/setup-bin dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: David Terpay <[email protected]>
…kip-mev#326) Bumps [github.com/gagliardetto/binary](https://github.com/gagliardetto/binary) from 0.7.7 to 0.8.0. - [Release notes](https://github.com/gagliardetto/binary/releases) - [Changelog](https://github.com/gagliardetto/binary/blob/master/CHANGELOG.md) - [Commits](gagliardetto/binary@v0.7.7...v0.8.0) --- updated-dependencies: - dependency-name: github.com/gagliardetto/binary dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Alex Johnson <[email protected]>
…mev#331) Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.63.0 to 1.63.2. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.63.0...v1.63.2) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Alex Johnson <[email protected]> Co-authored-by: David Terpay <[email protected]>
…skip-mev#330) Bumps [github.com/klauspost/compress](https://github.com/klauspost/compress) from 1.17.7 to 1.17.8. - [Release notes](https://github.com/klauspost/compress/releases) - [Changelog](https://github.com/klauspost/compress/blob/master/.goreleaser.yml) - [Commits](klauspost/compress@v1.17.7...v1.17.8) --- updated-dependencies: - dependency-name: github.com/klauspost/compress dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Alex Johnson <[email protected]> Co-authored-by: David Terpay <[email protected]>
* new market * gen * fix * wip * dep * ok * tidy * update * cute * clean * params * fix * len * cp * init * ok * cute * add * errors * fix * keeper test * nice * cdc * msg : * msg * clean * update * fix tests * query * query setup * query * query * init hooks * add to keeper * test * add hooks * genesis hook * fix * this is my legacy * ok * lint * init * market query * types * events * proto * module defs * beautify * Update x/mm2/types/market.go Co-authored-by: David Terpay <[email protected]> * Update x/mm2/types/market.go Co-authored-by: David Terpay <[email protected]> * fix * test * newline * remove * test * fix * fix * fix * fix * beautify * merchandise * fix * fix * fix * fix * fix * get params * test * comment * export func * test * invalid bech32 * check * bet * format * expand tests * feat(`x/marketmap`): init types and validation (skip-mev#266) * clean * new market * gen * fix * wip * dep * update * cute * clean * len * cp * ok * nice * Update x/mm2/types/market.go Co-authored-by: David Terpay <[email protected]> * Update x/mm2/types/market.go Co-authored-by: David Terpay <[email protected]> * fix * test * comment * expand tests * better errors --------- Co-authored-by: David Terpay <[email protected]> * fix * feat(`x/marketmap`): params type (skip-mev#267) * clean * new market * gen * fix * wip * dep * update * cute * clean * params * fix * len * cp * ok * nice * Update x/mm2/types/market.go Co-authored-by: David Terpay <[email protected]> * Update x/mm2/types/market.go Co-authored-by: David Terpay <[email protected]> * fix * test * newline * remove * comment * expand tests * fix --------- Co-authored-by: David Terpay <[email protected]> * feat(`x/marketmap`): genesis and validation (skip-mev#268) * bye * fix * 0 len * fix * fix vuln * fixington * fix * nolint * check * fix * feat(`x/marketmap`): keeper methods (skip-mev#270) * clean * new market * gen * fix * wip * dep * update * cute * clean * params * fix * len * cp * init * ok * cute * add * errors * fix * keeper test * nice * Update x/mm2/types/market.go Co-authored-by: David Terpay <[email protected]> * Update x/mm2/types/market.go Co-authored-by: David Terpay <[email protected]> * fix * test * newline * remove * test * fix * beautify * merchandise * comment * export func * test * expand tests * fix * bye * fix * fix vuln * check --------- Co-authored-by: David Terpay <[email protected]> * feat(`x/marketmap`): tx and msg service (skip-mev#273) * clean * new market * gen * fix * wip * dep * update * cute * clean * params * fix * len * cp * init * ok * cute * add * errors * fix * keeper test * nice * cdc * msg : * msg * clean * update * fix tests * Update x/mm2/types/market.go Co-authored-by: David Terpay <[email protected]> * Update x/mm2/types/market.go Co-authored-by: David Terpay <[email protected]> * fix * test * newline * remove * test * fix * fix * beautify * merchandise * fix * comment * export func * test * invalid bech32 * check * bet * format * expand tests * fix * bye * fix * 0 len * fix * fix vuln * fixington * nolint * check --------- Co-authored-by: David Terpay <[email protected]> * feat(`x/marketmap`): query server (skip-mev#275) * clean * new market * gen * fix * wip * dep * update * cute * clean * params * fix * len * cp * init * ok * cute * add * errors * fix * keeper test * nice * cdc * msg : * msg * clean * update * fix tests * query * query setup * query * query * Update x/mm2/types/market.go Co-authored-by: David Terpay <[email protected]> * Update x/mm2/types/market.go Co-authored-by: David Terpay <[email protected]> * fix * test * newline * remove * test * fix * fix * fix * beautify * merchandise * fix * fix * comment * export func * test * invalid bech32 * check * bet * format * expand tests * fix * bye * fix * 0 len * fix * fix vuln * fixington * fix * nolint * check --------- Co-authored-by: David Terpay <[email protected]> * feat(`x/marktmap`): keeper genesis (skip-mev#276) * clean * new market * gen * fix * wip * dep * update * cute * clean * params * fix * len * cp * init * ok * cute * add * errors * fix * keeper test * nice * cdc * msg : * msg * clean * update * fix tests * query * query setup * query * query * test * Update x/mm2/types/market.go Co-authored-by: David Terpay <[email protected]> * Update x/mm2/types/market.go Co-authored-by: David Terpay <[email protected]> * fix * test * newline * remove * test * fix * fix * fix * fix * beautify * merchandise * fix * fix * fix * get params * test * comment * export func * test * invalid bech32 * check * bet * format * expand tests * fix * bye * fix * 0 len * fix * fix vuln * fixington * fix * nolint * check * fix --------- Co-authored-by: David Terpay <[email protected]> * fix * feat(`x/marketmap`): keeper hooks (skip-mev#279) * clean * new market * gen * fix * wip * dep * update * cute * clean * params * fix * len * cp * init * ok * cute * add * errors * fix * keeper test * nice * cdc * msg : * msg * clean * update * fix tests * query * query setup * query * query * init hooks * add to keeper * test * add hooks * genesis hook * fix * this is my legacy * ok * lint * Update x/mm2/types/market.go Co-authored-by: David Terpay <[email protected]> * Update x/mm2/types/market.go Co-authored-by: David Terpay <[email protected]> * fix * test * newline * remove * test * fix * fix * fix * fix * beautify * merchandise * fix * fix * fix * fix * get params * test * comment * export func * test * invalid bech32 * check * bet * format * expand tests * fix * bye * fix * 0 len * fix * fix vuln * fixington * fix * nolint * check * fix * fix --------- Co-authored-by: David Terpay <[email protected]> * feat(`x/marketmap`): query cli (skip-mev#280) * init * market query * fix * feat(`x/marketmap`): events (skip-mev#281) * types * events --------- Co-authored-by: David Terpay <[email protected]> * feat(`x/marketmap`): add `Admin` param (skip-mev#293) * add admin * fix * better check * revert * update proto * clean * fix * set * test * fix * test * fix * proto * best * capacity * ok * refactor: Provider Ticker Interface (PR1) (skip-mev#322) * init * init * remove code that should not be here * remove code that should not be here v2 * testing nit * cr * removing decimals from if * refactor: API Price Providers with Provider Ticker Interface (PR2) (skip-mev#325) * init * more changes * api providers * more nits * cr * cr 2 * remove dec * refactor: WebSocket Providers with ProviderTickers interface (PR3) (skip-mev#328) * init * more changes * api providers * more nits * cr * cr 2 * init * nits * factory methods * oracle math done * done with build * done with build * done with dydx basic changes * updating * update * dydx provider done * done with oracle testing * done with providers * build * configs * config nit * nits * update aggregator * refactor: marketmap full conversion (skip-mev#333) * wip * suite * renames * renames * all tests passing * lint pass * fix e2e * fix? * fix * fix * fix * fixed forever * ok * nits * tidy * remove GetProvider * refactor: `mm2` -> `marketmap` (skip-mev#334) * wip * suite * renames * renames * all tests passing * lint pass * fix e2e * temp * bye * gen * fix * fmt * regen mocks * fix? * fix * fix * fix --------- Co-authored-by: David Terpay <[email protected]> --------- Co-authored-by: Alex Johnson <[email protected]> * chore: Cleaning up deadcode (skip-mev#337) * init * nit * tidy other readmes * more nits * chore: `marketmap` cleanup (skip-mev#338) * proto * fix * comment * comment out test * fix * fix --------- Co-authored-by: David Terpay <[email protected]> * ok * sure * tidy all * readme --------- Co-authored-by: David Terpay <[email protected]>
beer-1
force-pushed
the
fix/compute-gov-addr-after-config-changed
branch
from
fce820e to
e662fb1
Compare
Eric-Warehime
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
authtypes.NewModuleAddressinternally usesdk.Config()to decide the bech32 prefix of the acc address.In current implementation, the function is called before the config modification. so it is using
cosmosprefix to compute gov module address.This lead
sdk.AccAddress{}.String()always compute the address withcosmosbech32 prefix due to cache logic insidesdk.AccAddress. Also this leads gov module address stored withcosmos1prefixed string address in any chain.