Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: marketmap cleanup #338

Merged
merged 7 commits into from
Apr 10, 2024
Merged

chore: marketmap cleanup #338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
eb2be54
proto
Apr 10, 2024
95a76cb
fix
Apr 10, 2024
96328bf
comment
Apr 10, 2024
b228cb6
comment out test
Apr 10, 2024
689ea2f
fix
Apr 10, 2024
e708bab
fix
Apr 10, 2024
ea80598
Merge branch 'feat/market-map-2' into chore/mm-cleanup
davidterpay Apr 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/slinky/marketmap/v1/market.pulsar.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions api/slinky/marketmap/v1/query.pulsar.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

62 changes: 31 additions & 31 deletions api/slinky/marketmap/v1/tx.pulsar.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

32 changes: 17 additions & 15 deletions api/slinky/marketmap/v1/tx_grpc.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion proto/slinky/marketmap/v1/market.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ message ProviderConfig {
string off_chain_ticker = 2;

// NormalizeByPair is the currency pair for this ticker to be normalized by.
// For example, if the desired Ticker is BTD/USD, this market could be reached
// For example, if the desired Ticker is BTC/USD, this market could be reached
// using: OffChainTicker = BTC/USDT NormalizeByPair = USDT/USD This field is
// optional and nullable.
slinky.types.v1.CurrencyPair normalize_by_pair = 3;
Expand Down
2 changes: 1 addition & 1 deletion proto/slinky/marketmap/v1/query.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ message MarketMapResponse {
message MarketRequest {
// CurrencyPair is the currency pair associated with the market being
// requested.
slinky.types.v1.CurrencyPair currency_pair = 3
slinky.types.v1.CurrencyPair currency_pair = 1
[ (gogoproto.nullable) = false ];
}

Expand Down
5 changes: 3 additions & 2 deletions proto/slinky/marketmap/v1/tx.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,9 @@ service Msg {
// UpdateMarkets updates markets from the given message.
rpc UpdateMarkets(MsgUpdateMarkets) returns (MsgUpdateMarketsResponse);

// Params defines a method for updating the x/marketmap module parameters.
rpc Params(MsgParams) returns (MsgParamsResponse);
// UpdateParams defines a method for updating the x/marketmap module
// parameters.
rpc UpdateParams(MsgParams) returns (MsgParamsResponse);

// RemoveMarketAuthorities defines a method for removing market authorities
// from the x/marketmap module. the signer must be the admin.
Expand Down
Loading
Loading