Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: market map enable helper functions #584

Merged
merged 6 commits into from
Jul 10, 2024
Merged

feat: market map enable helper functions #584

merged 6 commits into from
Jul 10, 2024

Conversation

aljo242
Copy link
Contributor

@aljo242 aljo242 commented Jul 9, 2024

Closes: BLO-1505

Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.62%. Comparing base (f342fcf) to head (9721be1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #584      +/-   ##
==========================================
+ Coverage   56.57%   56.62%   +0.04%     
==========================================
  Files         248      248              
  Lines       12703    12717      +14     
==========================================
+ Hits         7187     7201      +14     
  Misses       4806     4806              
  Partials      710      710              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@technicallyty technicallyty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. they only needed this in keeper? they didnt want it exposed over grpc?

@aljo242
Copy link
Contributor Author

aljo242 commented Jul 9, 2024

LGTM. they only needed this in keeper? they didnt want it exposed over grpc?

yeah, they just want to have helper functions they can call from the keeper

@aljo242 aljo242 merged commit 7c526fa into main Jul 10, 2024
16 checks passed
@aljo242 aljo242 deleted the feat/mm-enable branch July 10, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants