docs: more examples + guidance on remote-signers #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nivasan1
requested review from
davidterpay,
aljo242,
Eric-Warehime and
technicallyty
as code owners
davidterpay
reviewed
Jul 10, 2024
docs/integrations/neutron.mdx
Outdated
| @@ -29,10 +29,13 @@ title: Neutron | |||
| slinky | |||
| ``` | |||
|
|
|||
| > Notice, some default values may need to change depending on how you've setup your node + connect-sidecar. See the **marketmap-provider** [section](/validator/flags-guide#marketmap-provider) of the [flags-guide](/validator/flags-guide) | |||
| > Notice, some default values may need to change depending on how you've setup your node + connect-sidecar. See the **marketmap-provider** [section](/validator/flags-guide#marketmap-provider) of the [flags-guide](/validator/flags-guide) an example config that over-rides relevant slinky defaults is [here](/validator/validator-connect-config#overriding-the-market-map-oracle-server-endpoint) | |||
There was a problem hiding this comment.
Suggested change
| > Notice, some default values may need to change depending on how you've setup your node + connect-sidecar. See the **marketmap-provider** [section](/validator/flags-guide#marketmap-provider) of the [flags-guide](/validator/flags-guide) an example config that over-rides relevant slinky defaults is [here](/validator/validator-connect-config#overriding-the-market-map-oracle-server-endpoint) | |
| > Notice, some default values may need to change depending on how you've setup your node + connect-sidecar. See the **marketmap-provider** [section](/validator/flags-guide#marketmap-provider) of the [flags-guide](/validator/flags-guide). An example config that over-rides relevant slinky defaults is [here](/validator/validator-connect-config#overriding-the-market-map-oracle-server-endpoint) |
davidterpay
approved these changes
Jul 10, 2024
technicallyty
approved these changes
Jul 10, 2024
bpiv400
approved these changes
Jul 10, 2024
Co-authored-by: Tyler <[email protected]>
Co-authored-by: Tyler <[email protected]>
aljo242
approved these changes
Jul 11, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #593 +/- ##
=======================================
Coverage 56.62% 56.62%
=======================================
Files 248 248
Lines 12717 12717
=======================================
Hits 7201 7201
Misses 4806 4806
Partials 710 710 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.