Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reduce ABCI logging [BLO-1513] #595

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Conversation

nivasan1
Copy link
Contributor

In This PR

  • I remove unnecessary Info logs to Error or Debug in our price-aggregation performed per block.
  • On neutron, these logs output basically 65 times per block, basically completely drowning out all other logs from modules / comet
  • Now this behavior only happens on debug

Copy link

codecov bot commented Jul 11, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 56.62%. Comparing base (44ab66d) to head (47d128f).

Files Patch % Lines
pkg/math/voteweighted/voteweighted.go 40.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #595   +/-   ##
=======================================
  Coverage   56.62%   56.62%           
=======================================
  Files         248      248           
  Lines       12717    12717           
=======================================
  Hits         7201     7201           
  Misses       4806     4806           
  Partials      710      710           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nivasan1 nivasan1 merged commit 229db73 into main Jul 12, 2024
15 of 16 checks passed
@nivasan1 nivasan1 deleted the nv/reduce-app-side-logging branch July 12, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants