Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: App Config (app.toml) Parsing Fix #624

Merged
merged 4 commits into from
Jul 24, 2024
Merged

Conversation

davidterpay
Copy link
Contributor

app.toml automatically fills in fields with defaults even if they are not set so our parsing logic has to take the defaults into account.

@davidterpay davidterpay marked this pull request as ready for review July 24, 2024 18:37
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

Attention: Patch coverage is 64.51613% with 11 lines in your changes missing coverage. Please review.

Project coverage is 56.48%. Comparing base (ca2a9e1) to head (da2c996).
Report is 1 commits behind head on main.

Files Patch % Lines
oracle/config/app.go 64.51% 10 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #624      +/-   ##
==========================================
- Coverage   56.48%   56.48%   -0.01%     
==========================================
  Files         250      250              
  Lines       13045    13068      +23     
==========================================
+ Hits         7369     7381      +12     
- Misses       4968     4979      +11     
  Partials      708      708              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

oracle/config/app.go Show resolved Hide resolved
oracle/config/app.go Show resolved Hide resolved
@davidterpay davidterpay merged commit 9f85f7f into main Jul 24, 2024
16 checks passed
@davidterpay davidterpay deleted the terpay/app-config-parsing branch July 24, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants