Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add flags for config fields #625

Merged

Conversation

technicallyty
Copy link
Contributor

  • adds flags to edit parts of the oracle config
  • updates docs with new flags

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 40 lines in your changes missing coverage. Please review.

Project coverage is 56.32%. Comparing base (9f85f7f) to head (9f891fe).

Files Patch % Lines
cmd/slinky/main.go 0.00% 40 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #625      +/-   ##
==========================================
- Coverage   56.49%   56.32%   -0.18%     
==========================================
  Files         250      250              
  Lines       13068    13108      +40     
==========================================
  Hits         7383     7383              
- Misses       4977     5017      +40     
  Partials      708      708              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

docs/validators/configuration.mdx Outdated Show resolved Hide resolved
Copy link
Contributor

@aljo242 aljo242 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm just some annoying lint stuff

@technicallyty
Copy link
Contributor Author

CI is failing for unrelated reason, gonna merge dis

@technicallyty technicallyty merged commit c5371eb into main Jul 25, 2024
14 of 15 checks passed
@technicallyty technicallyty deleted the tyler/blo-1549-add-connect-flags-for-metrics-config branch July 25, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants