Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow for no bank balances in all simulations (backport #137) #138

Open
wants to merge 1 commit into
base: sdk-47
Choose a base branch
from

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Aug 26, 2024

  • Always use 0denom dummy fee value in simulation
  • Add in calculated gas consumption amount to account for keeper codepaths that are not hit because of this (in sim only)
  • add non-mocked bank keeper testing
  • lint fixes due to version bump
    This is an automatic backport of pull request fix: allow for no bank balances in all simulations #137 done by Mergify.

* init

* recreate and fix bug

* helper

* ante tests

* ok

* fix via gas consume call during simulation

* test

* revert

* lint fix

* retract more

* replace linter

* set lint to what we use

(cherry picked from commit f1f216e)

# Conflicts:
#	x/feemarket/ante/expected_keepers.go
#	x/feemarket/ante/mocks/mock_bank_keeper.go
#	x/feemarket/ante/suite/suite.go
#	x/feemarket/post/fee_test.go
Copy link
Author

mergify bot commented Aug 26, 2024

Cherry-pick of f1f216e has failed:

On branch mergify/bp/sdk-47/pr-137
Your branch is up to date with 'origin/sdk-47'.

You are currently cherry-picking commit f1f216e.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   .github/workflows/lint.yml
	modified:   .golangci.yml
	modified:   go.mod
	modified:   x/feemarket/ante/fee.go
	modified:   x/feemarket/ante/fee_test.go
	modified:   x/feemarket/post/fee.go
	modified:   x/feemarket/types/state.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   x/feemarket/ante/expected_keepers.go
	both modified:   x/feemarket/ante/mocks/mock_bank_keeper.go
	both modified:   x/feemarket/ante/suite/suite.go
	both modified:   x/feemarket/post/fee_test.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant