Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duckling bug fix #219

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Duckling bug fix #219

wants to merge 1 commit into from

Conversation

Aaron-skit
Copy link

This is patch fix for handling of Amount of Money dimension bug in Duckling

@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 33.33333% with 6 lines in your changes missing coverage. Please review.

Project coverage is 88.73%. Comparing base (3805cac) to head (07fc2a6).

Files with missing lines Patch % Lines
dialogy/types/entity/amount_of_money/__init__.py 33.33% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #219      +/-   ##
==========================================
- Coverage   88.88%   88.73%   -0.16%     
==========================================
  Files          63       63              
  Lines        3213     3222       +9     
==========================================
+ Hits         2856     2859       +3     
- Misses        357      363       +6     
Flag Coverage Δ
unittests 88.73% <33.33%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants