Add a new option sensitive, which can be used to hide sensitive args #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SubhrajitPrusty
force-pushed
the
feat-add-sensitive-logging
branch
from
1359ee6 to
8535d3b
Compare
|
This is better suited for the application level rather than a framework. I would recommend utilising Stringer (To implement String()) or something like this. |
SubhrajitPrusty
force-pushed
the
feat-add-sensitive-logging
branch
2 times, most recently
from
3a28a75 to
3ce87a1
Compare
vabshere
reviewed
Jun 10, 2024
- lets you log messages without showing the values
SubhrajitPrusty
force-pushed
the
feat-add-sensitive-logging
branch
from
3ce87a1 to
aa2f1c0
Compare
SubhrajitPrusty
changed the title
vabshere
approved these changes
Jun 11, 2024
ydlamba
reviewed
Jun 12, 2024
ydlamba
approved these changes
Jun 12, 2024
SubhrajitPrusty
force-pushed
the
feat-add-sensitive-logging
branch
from
d2de463 to
5b58787
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lets you log messages without showing the values