Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fe): confirm modal when leaving settings page #2261

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

jihorobert
Copy link
Contributor

@jihorobert jihorobert commented Dec 19, 2024

Description

  • Settings 페이지 이탈 시 Confirm Modal 디자인대로 구현
    • 기존에는 window 디폴트 모달창 이용
  • Shadcn AlertDialog -> AlertDialogOverlay 에 darkMode 선택 여부 기능 추가해서
    • true일 경우 배경을 어둡게
스크린샷 2024-12-19 오후 1 33 38
  • false일 경우 배경을 밝게(default)
스크린샷 2024-12-19 오후 1 36 13 -> 코드당에서는 밝은 모드를 더 쓰는 것 같음

closes TAS-1113


Before submitting the PR, please make sure you do the following

@coolify-skkuding
Copy link

coolify-skkuding bot commented Dec 19, 2024

The preview deployment is ready. 🟢

Open Preview | Open Build Logs

Last updated at: 2024-12-23 01:53:16 CET

Copy link

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 파일 컴포넌트로 한 이유가 있나요?! utils로 빼는 건 어떨까요??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Pending
Development

Successfully merging this pull request may close these issues.

2 participants