Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: eslint migration #2265

Merged
merged 12 commits into from
Jan 9, 2025
Merged

chore: eslint migration #2265

merged 12 commits into from
Jan 9, 2025

Conversation

eunnbi
Copy link
Contributor

@eunnbi eunnbi commented Dec 22, 2024

Description

  • ESLint flat config migration
  • Github CI Action 실패하는 문제 수정

Additional context

closes TAS-490


Before submitting the PR, please make sure you do the following

@eunnbi eunnbi self-assigned this Dec 22, 2024
package.json Show resolved Hide resolved
eslint.config.mjs Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@eunnbi eunnbi force-pushed the t490-eslint-migration branch from cd11a0c to 0aaeece Compare December 22, 2024 06:18
@eunnbi eunnbi force-pushed the t490-eslint-migration branch from 0aaeece to 53bf8df Compare December 22, 2024 06:20
Copy link

New ESLint Configuration

@eunnbi eunnbi marked this pull request as ready for review January 3, 2025 11:29
@eunnbi eunnbi force-pushed the t490-eslint-migration branch from 9e5f68d to 621b778 Compare January 7, 2025 11:32
@eunnbi eunnbi force-pushed the t490-eslint-migration branch from 621b778 to 2e1e8fc Compare January 7, 2025 11:35
Copy link
Member

@B0XERCAT B0XERCAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

프론트 lint 룰이랑 CI 확인했습니다!
고생 많으셨어요~

Copy link
Member

@jimin9038 jimin9038 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI 변경 사항 / Eslint 변경 사항 확인했습니다!
백엔드쪽만 균서님이 한번 더 봐주시면 좋을 것 같아요!
고생 많으셨어요!

Copy link
Contributor

@gyunseo gyunseo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GOOD.

@eunnbi eunnbi merged commit d9bf2e2 into main Jan 9, 2025
9 checks passed
@eunnbi eunnbi deleted the t490-eslint-migration branch January 9, 2025 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants