Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fe): add testcase result color #2332

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

dayeoni
Copy link
Contributor

@dayeoni dayeoni commented Jan 25, 2025

Description

  1. Tab 개수에 따라 'Testcase Result'표시 방법을 추가했습니다.
    (1) 5개 미만: 'Testcase Result'
    (2) 5개 이상 7개 미만: 'Testcase Res...'(말줄임)
    (3) 7개 이상: 'TC Res'

  2. Expected output과 Output을 비교하고 비교 결과를 색을 통해 표시했습니다.
    (1) 동일: 흰색
    (2) Expected output에만 있는 글자: 초록색
    (3) Output에만 있는 글자: 빨간색

image image

Additional context

https://neil.fraser.name/software/diff_match_patch/demos/diff.html

closes TAS-1105

Before submitting the PR, please make sure you do the following

@coolify-skkuding
Copy link

coolify-skkuding bot commented Jan 25, 2025

The preview deployment is ready. 🟢

Open Preview | Open Build Logs

Last updated at: 2025-02-03 08:05:00 CET

Copy link
Contributor

@Kohminchae Kohminchae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
탭 높이 맞춰주세요!

Copy link
Contributor

@Kohminchae Kohminchae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
image
탭이 5개일 때 탭 이름의 너비가 확 줄어드는데 원래 디자인인가요?
그리고 Testcase Res... 로 표기될 때 padding이 있어야 할 것 같아요!

@Kohminchae
Copy link
Contributor

Kohminchae commented Jan 26, 2025

notion task 봇 왜 안뜨지? closes TAS-1105 이렇게 하면 되려나?

@Kimhyojung0810
Copy link
Contributor

notion task 봇 왜 안뜨지? closes TAS-1105 이렇게 하면 되려나?
정답 ~~~~~~ !!!

Copy link

@B0XERCAT B0XERCAT self-requested a review February 4, 2025 06:24
Copy link
Member

@B0XERCAT B0XERCAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM이요~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Approved 👌
Development

Successfully merging this pull request may close these issues.

4 participants