Create sklmessages_te_in.properties #667
Conversation
WalkthroughThe changes introduce a new properties file for Telugu (India) localization in the application. This file contains key-value pairs that translate various user interface elements, including general messages, sidebar labels, button texts, and alerts. The translations cover aspects related to game management, installation settings, and user interactions, ensuring a comprehensive localization for Telugu-speaking users. Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Outside diff range and nitpick comments (1)
assets/launcher/lang/sklmessages_te_IN.properties (1)
64-67: Fix indentation in crash alert sectionEnsure consistent indentation in the properties file to maintain readability and prevent potential parsing issues.
crash.alert.title=అయ్యో! గేమ్ క్రాష్ అయింది -crash.alert.text=కానీ మేము మీ సమస్యకు సాధ్యమైన పరిష్కారాన్ని కనుగొన్నాము. మీరు ఇప్పుడు దాన్ని తనిఖీ చేయాలనుకుంటున్నారా? -crash.alert.button.ignore=విస్మరించండి -crash.alert.button.open=వెబ్సైట్ను తెరవండి +crash.alert.text=కానీ మేము మీ సమస్యకు సాధ్యమైన పరిష్కారాన్ని కనుగొన్నాము. మీరు ఇప్పుడు దాన్ని తనిఖీ చేయాలనుకుంటున్నారా? +crash.alert.button.ignore=విస్మరించండి +crash.alert.button.open=వెబ్సైట్ను తెరవండి
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
assets/launcher/lang/sklmessages_te_IN.properties(1 hunks)
🔇 Additional comments (3)
assets/launcher/lang/sklmessages_te_IN.properties (3)
1-2: LGTM! Language identification is correct.
The language code and name follow ISO standards and conventions.
80-81: LGTM! Proper attribution of translation work.
Translation credit is correctly given to the PR author.
1-200: Verify translation completeness
Let's ensure all keys from the base English properties file are translated.
✅ Verification successful
The previous script didn't find the English properties file. Let's try a different approach to verify the translation completeness.
Let's compare the Telugu translation with the US English version to ensure completeness.
Let's try a simpler approach using basic shell commands to compare the files.
Telugu translation is complete and well-structured
The verification shows that:
- Both English and Telugu files have the same number of keys (169)
- No keys are missing from the Telugu translation
- No extra keys are present in the Telugu translation
- No empty translations were found
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Compare keys between English and Telugu properties files
# Find the English properties file
echo "Searching for English properties file..."
fd -t f "sklmessages_en.properties" | while read -r en_file; do
echo "Comparing with $en_file..."
# Extract keys from both files and compare
grep -o '^[^=]*=' "$en_file" | sort > /tmp/en_keys
grep -o '^[^=]*=' "assets/launcher/lang/sklmessages_te_IN.properties" | sort > /tmp/te_keys
# Show missing keys
echo "Keys present in English but missing in Telugu:"
comm -23 /tmp/en_keys /tmp/te_keys
done
Length of output: 144
Script:
#!/bin/bash
# First, let's find all properties files in the launcher/lang directory
echo "Available language files:"
fd -t f "sklmessages_.*\.properties" assets/launcher/lang/
# Let's examine the content structure of both files
echo -e "\nStructure of Telugu translation file:"
grep -v '^#' assets/launcher/lang/sklmessages_te_IN.properties | grep -v '^$' | wc -l
# Let's check for any duplicate keys
echo -e "\nChecking for duplicate keys in Telugu translation:"
grep -v '^#' assets/launcher/lang/sklmessages_te_IN.properties | grep '=' | cut -d'=' -f1 | sort | uniq -d
Length of output: 2778
Script:
#!/bin/bash
# Compare Telugu translation with US English
echo "Comparing key counts:"
echo "US English keys:"
grep -v '^#' assets/launcher/lang/sklmessages_en_US.properties | grep '=' | wc -l
echo "Telugu keys:"
grep -v '^#' assets/launcher/lang/sklmessages_te_IN.properties | grep '=' | wc -l
echo -e "\nKeys in US English but missing in Telugu:"
grep -v '^#' assets/launcher/lang/sklmessages_en_US.properties | grep '=' | cut -d'=' -f1 > /tmp/en_keys
grep -v '^#' assets/launcher/lang/sklmessages_te_IN.properties | grep '=' | cut -d'=' -f1 > /tmp/te_keys
comm -23 <(sort /tmp/en_keys) <(sort /tmp/te_keys)
Length of output: 748
Script:
#!/bin/bash
# Compare keys using basic commands
echo "Checking for differences in keys:"
# Create sorted lists of keys
grep -v '^#' assets/launcher/lang/sklmessages_en_US.properties | grep '=' | cut -d'=' -f1 | sort > /tmp/en_sorted
grep -v '^#' assets/launcher/lang/sklmessages_te_IN.properties | grep '=' | cut -d'=' -f1 | sort > /tmp/te_sorted
# Show any differences
echo "Keys only in English file:"
diff /tmp/en_sorted /tmp/te_sorted | grep '^<' || echo "No missing keys"
echo -e "\nKeys only in Telugu file:"
diff /tmp/en_sorted /tmp/te_sorted | grep '^>' || echo "No extra keys"
# Check for any empty translations
echo -e "\nChecking for empty translations in Telugu file:"
grep '=$' assets/launcher/lang/sklmessages_te_IN.properties || echo "No empty translations found"
Length of output: 810
|
The PR should be named |
SpaciousCoder78
changed the title
|
Done, please check |
I've added te_IN translation in this PR
Summary by CodeRabbit
New Features
Bug Fixes