Merge pull request #215 from skni-kod/issue-214

fix: #214 user cannot add more than 1 grade under the material
skni-kod · Dec 15, 2024 · 004c85a · 004c85a
2 parents c31a45d + ab4f6a6
commit 004c85a
Show file tree

Hide file tree

Showing 3 changed files with 41 additions and 0 deletions.
diff --git a/...ckend/src/main/java/pl/sknikod/kodemybackend/infrastructure/database/GradeRepository.java b/...ckend/src/main/java/pl/sknikod/kodemybackend/infrastructure/database/GradeRepository.java
@@ -41,4 +41,6 @@ public interface GradeRepository extends JpaRepository<Grade, Long> {
 
     @Query("SELECT g FROM Grade g WHERE g.material.id = :materialId AND g.createdDate BETWEEN :from AND :to")
     Page<Grade> findGradesByMaterialInDateRange(Long materialId, LocalDateTime from, LocalDateTime to, Pageable pageable);
+
+    boolean existsByMaterialIdAndUserId(Long materialId, Long userId);
 }
diff --git a/kodemy-backend/src/main/java/pl/sknikod/kodemybackend/infrastructure/store/GradeStore.java b/kodemy-backend/src/main/java/pl/sknikod/kodemybackend/infrastructure/store/GradeStore.java
@@ -16,6 +16,7 @@
 import pl.sknikod.kodemybackend.infrastructure.database.GradeRepository;
 import pl.sknikod.kodemybackend.infrastructure.database.Material;
 import pl.sknikod.kodemybackend.infrastructure.database.MaterialRepository;
+import pl.sknikod.kodemycommons.exception.AlreadyExists409Exception;
 import pl.sknikod.kodemycommons.util.PrincipalUtil;
 import pl.sknikod.kodemycommons.exception.NotFound404Exception;
 import pl.sknikod.kodemycommons.exception.content.ExceptionMsgPattern;
@@ -93,6 +94,14 @@ public Try<Grade> addGrade(Long materialId, double value) {
                             ExceptionMsgPattern.ENTITY_NOT_FOUND_BY_PARAM, Material.class.getSimpleName(), "id", materialId
                     );
                 })
+                .andThenTry(() -> {
+                    var userId = principalUtil.getPrincipal().get().getId();
+                    if (gradeRepository.existsByMaterialIdAndUserId(materialId, userId)) {
+                        throw new AlreadyExists409Exception(
+                                ExceptionMsgPattern.ENTITY_ALREADY_EXISTS, "userId"
+                        );
+                    }
+                })
                 .mapTry(unused -> new Grade(value, principalUtil.getPrincipal().get().getId(), materialId))
                 .map(gradeRepository::save)
                 .onFailure(th -> log.error("Cannot add grade", th));

diff --git a/kodemy-backend/src/test/groovy/unit/infrastructure/store/GradeStoreSpec.groovy b/kodemy-backend/src/test/groovy/unit/infrastructure/store/GradeStoreSpec.groovy
@@ -10,6 +10,7 @@ import pl.sknikod.kodemybackend.infrastructure.database.GradeRepository
 import pl.sknikod.kodemybackend.infrastructure.database.MaterialRepository
 import pl.sknikod.kodemybackend.infrastructure.store.GradeStore
 import pl.sknikod.kodemybackend.infrastructure.store.UserStore
+import pl.sknikod.kodemycommons.exception.AlreadyExists409Exception
 import pl.sknikod.kodemycommons.exception.NotFound404Exception
 import pl.sknikod.kodemycommons.security.UserPrincipal
 import pl.sknikod.kodemycommons.util.PrincipalUtil
@@ -146,6 +147,35 @@ class GradeStoreSpec extends Specification {
         Assert.that(grade == result)
     }
 
+
+    def "same user cannot add more than 1 grade under the material"() {
+        given:
+            materialRepository.existsById(MATERIAL_ID) >> true
+            principalUtil.getPrincipal() >> Optional.of(new UserPrincipal(
+                    USER_ID, "", false, false,
+                    false, true, new HashSet<SimpleGrantedAuthority>()
+            ))
+        and:
+            def savedGrades = []
+            gradeRepository.save(_ as Grade) >> { Grade g ->
+                savedGrades << g
+                return g
+            }
+            gradeRepository.existsByMaterialIdAndUserId(_ as Long, _ as Long) >> { Long materialIdArg, Long userIdArg ->
+                savedGrades.any { it.material.id == materialIdArg && it.userId == userIdArg }
+            }
+
+        when: "add grade to the same material more than 1 time"
+            def firstAdd = gradeStore.addGrade(1, 1)
+            def secondAdd = gradeStore.addGrade(1, 2)
+
+        then: "second addition is failure"
+            firstAdd.isSuccess()
+            secondAdd.isFailure()
+            secondAdd.failed().get() instanceof AlreadyExists409Exception
+
+    }
+
     def "shouldThrowWhenAddGrade"() {
         given:
         materialRepository.existsById(MATERIAL_ID) >> false