feat: add endpoints for fetching and updating user data, add validati… #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marioooo0o
requested changes
Dec 17, 2024
| return [ | ||
| 'name' => 'string|min:2|max:30|regex:/^[a-zA-ZÀ-ž\s\'-]+$/', | ||
| 'last_name' => 'string|min:2|max:30|regex:/^[a-zA-ZÀ-ž\s\'-]+$/', | ||
| 'email' => 'email|max:255', |
There was a problem hiding this comment.
dodaj tutaj również unique
Comment on lines
28
to
33
|
|
||
| $table->string('card_first_name')->nullable(); | ||
| $table->string('card_last_name')->nullable(); | ||
| $table->string('card_number')->nullable(); | ||
| $table->string('card_expiry_date')->nullable(); | ||
| $table->string('card_cvv')->nullable(); |
There was a problem hiding this comment.
Przenieść do oddzielenej tabeli z relacją 1:1
There was a problem hiding this comment.
Zadbać o odpowiednie przechowywanie danych, ich zwracanie oraz szyfrowanie
Comment on lines
80
to
90
| $data = $request->validated(); | ||
| $user = auth()->user(); | ||
|
|
||
| try { | ||
| $user->update($data); | ||
| } | ||
| catch (Exception $e) | ||
| { | ||
| return response()->json(['message' => "Failed to update user's profile!"], Response::HTTP_INTERNAL_SERVER_ERROR); | ||
| } | ||
| return response()->json(['success' => true], Response::HTTP_OK); |
There was a problem hiding this comment.
Użycie struktury stworzonej w Course
marioooo0o
requested changes
Dec 18, 2024
| return [ | ||
| 'name' => 'string|min:2|max:30|regex:/^[a-zA-ZÀ-ž\s\'-]+$/', | ||
| 'last_name' => 'string|min:2|max:30|regex:/^[a-zA-ZÀ-ž\s\'-]+$/', | ||
| 'email' => 'email|max:255|unique:users,email', |
There was a problem hiding this comment.
Sprawdz proszę jak zachowa się kontroler kiedy podasz ten sam email w update
Comment on lines
+32
to
+35
| private function maskCvv(string $cvv): string | ||
| { | ||
| return str_repeat('*', strlen($cvv)); | ||
| } |
There was a problem hiding this comment.
Czy cvv nie powinien zachowywać się podobnie jak hasło, tzn ze nie jest dostępne w resource, a przy potwierdzaniu transakcji podawany jest cvv i sprawdzany hash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…on rules